Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Threat Intel] Fix IOC expiration duration character casting in painless script #8786

Merged
merged 5 commits into from
Jan 4, 2024
Merged

[Threat Intel] Fix IOC expiration duration character casting in painless script #8786

merged 5 commits into from
Jan 4, 2024

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Dec 22, 2023 •
edited
Loading

Proposed commit message

Fixes the bug explained in #8785.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@kcreddy kcreddy self-assigned this Dec 22, 2023
@kcreddy kcreddy changed the title [Threat Intel] Fix IOC expiration duration character casting [Threat Intel] Fix IOC expiration duration character casting in painless script Dec 22, 2023
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@kcreddy kcreddy marked this pull request as ready for review December 26, 2023 05:47
@kcreddy kcreddy requested a review from a team as a code owner December 26, 2023 05:47
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

chemamartinez
chemamartinez approved these changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@chemamartinez chemamartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kcreddy kcreddy merged commit 0c7c64e into elastic:main Jan 4, 2024
3 checks passed
@elasticmachine
Copy link

Package ti_anomali - 1.19.1 containing this change is available at https://epr.elastic.co/search?package=ti_anomali

@elasticmachine
Copy link

Package ti_otx - 1.23.1 containing this change is available at https://epr.elastic.co/search?package=ti_otx

@elasticmachine
Copy link

Package ti_threatq - 1.24.1 containing this change is available at https://epr.elastic.co/search?package=ti_threatq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chemamartinez chemamartinez chemamartinez approved these changes

Assignees

@kcreddy kcreddy

Labels
bugfix Integration:AlienVaultOTX Integration:Anomali Integration:ThreatQ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix IOC expiration duration character casting for ti_* packages
3 participants
@kcreddy @elasticmachine @chemamartinez