Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fortinet_fortigate]Adapt event.module value #8853

Merged
merged 1 commit into from
Jan 11, 2024
Merged

[fortinet_fortigate]Adapt event.module value #8853

merged 1 commit into from
Jan 11, 2024

Conversation

bhapas
Copy link
Contributor

@bhapas bhapas commented Jan 11, 2024 •
edited
Loading

Proposed commit message

See Title

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@bhapas bhapas requested a review from a team as a code owner January 11, 2024 09:20
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

P1llus
P1llus reviewed Jan 11, 2024
View reviewed changes
Copy link
Member

@P1llus P1llus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some comments, feel free to approach it the way you feel is best.

I do not know how constant_keywords will react on this however, when a datastream is rolled over I assume its fine, but since that field only accept 1 unique value, then maybe it will break the aggregations between old and new data?

packages/fim/data_stream/event/fields/base-fields.yml Outdated Show resolved Hide resolved
@bhapas bhapas requested review from a team as code owners January 11, 2024 10:28
@bhapas bhapas changed the title [fortinet_fortigate][fim] Adapt event.dataset and event.module values [fortinet_fortigate]Adapt event.module values Jan 11, 2024
@bhapas bhapas changed the title [fortinet_fortigate]Adapt event.module values [fortinet_fortigate]Adapt event.module value Jan 11, 2024
@bhapas bhapas requested review from kcreddy and P1llus January 11, 2024 10:33
kcreddy
kcreddy approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

It would be nice to verify Marius' comment.

I do not know how constant_keywords will react on this however, when a datastream is rolled over I assume its fine, but since that field only accept 1 unique value, then maybe it will break the aggregations between old and new data?

@bhapas bhapas merged commit 6c808f4 into elastic:main Jan 11, 2024
3 checks passed
@nicpenning
Copy link
Contributor

FYI - The PR referencing this change is incorrect - Likely from Copy/Paste from previous PR.

Should be #8853 instead of 8670
image

@bhapas bhapas mentioned this pull request Jan 14, 2024
Merged
@andrewkroh andrewkroh added the Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

@P1llus P1llus Awaiting requested review from P1llus

Assignees
No one assigned
Labels
Integration:fortinet_fortigate Fortinet FortiGate Firewall Logs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fortinet Fortigate Integration Event Module Name
6 participants
@bhapas @elasticmachine @nicpenning @P1llus @kcreddy @andrewkroh