Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cisco_asa,cisco_ftd: retain source and destination user emails if present #8898

Merged
merged 1 commit into from Jan 17, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jan 16, 2024

Proposed commit message

See title.

Note that the suggested approach was not used in order to ensure that he workgroup domain prefix is removed from the email address.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Team:Security-External Integrations Integration:CiscoFTD Cisco FTD Firepower Threat Defense Integration:CiscoASA Cisco ASA labels Jan 16, 2024
@efd6 efd6 self-assigned this Jan 16, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @efd6

@efd6 efd6 marked this pull request as ready for review January 16, 2024 22:44
@efd6 efd6 requested a review from a team as a code owner January 16, 2024 22:44
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 merged commit f3141bc into elastic:main Jan 17, 2024
3 checks passed
@elasticmachine
Copy link

Package cisco_asa - 2.30.0 containing this change is available at https://epr.elastic.co/search?package=cisco_asa

@elasticmachine
Copy link

Package cisco_ftd - 3.1.0 containing this change is available at https://epr.elastic.co/search?package=cisco_ftd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:CiscoASA Cisco ASA Integration:CiscoFTD Cisco FTD Firepower Threat Defense
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cisco] Populating source.user.email field
3 participants