Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

m365_defender: add geoip processing to {source,destination}.ip #8899

Merged
merged 1 commit into from Jan 17, 2024
Merged

m365_defender: add geoip processing to {source,destination}.ip #8899

merged 1 commit into from Jan 17, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jan 17, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 self-assigned this Jan 17, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 force-pushed the 8891-m365_defender branch 2 times, most recently from f8b8e7f to cb0417e Compare January 17, 2024 03:55
@efd6 efd6 marked this pull request as ready for review January 17, 2024 03:57
@efd6 efd6 requested a review from a team as a code owner January 17, 2024 03:57
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

kcreddy
kcreddy reviewed Jan 17, 2024
View reviewed changes
packages/m365_defender/changelog.yml Outdated
changes:
- description: Add geoip processing to source and destination IP fields.
type: enhancement
link: https://github.com/elastic/integrations/pull/1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pr number

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

bhapas
bhapas approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please merge once the PR number in changelog is fixed.

kcreddy
kcreddy approved these changes Jan 17, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@efd6 efd6 merged commit 51b18d4 into elastic:main Jan 17, 2024
3 checks passed
@elasticmachine
Copy link

Package m365_defender - 2.6.0 containing this change is available at https://epr.elastic.co/search?package=m365_defender

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

@bhapas bhapas bhapas approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration: M365_Defender
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[M365 Defender] Expand use of GeoIP Processor
4 participants
@efd6 @elasticmachine @kcreddy @bhapas