Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[O11y][ActiveMQ] Resolve host.ip field conflict #8927

Merged
merged 5 commits into from
Jan 22, 2024
Merged

[O11y][ActiveMQ] Resolve host.ip field conflict #8927

merged 5 commits into from
Jan 22, 2024

Conversation

harnish-elastic
Copy link
Contributor

Proposed commit message

  • Added host.ip to ecs.yml file to resolve host.ip field conflict
  • Provided troubleshooting for the existing users if they are facing the conflicting issue.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

Related issues

@harnish-elastic harnish-elastic self-assigned this Jan 18, 2024
@harnish-elastic harnish-elastic requested a review from a team as a code owner January 18, 2024 09:13
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

niraj-elastic
niraj-elastic approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@niraj-elastic niraj-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

harnish-elastic and others added 2 commits January 19, 2024 16:28
@harnish-elastic @ritalwar
Update packages/activemq/_dev/build/docs/README.md
495e97d 
Co-authored-by: Richa Talwar <102972658+ritalwar@users.noreply.github.com>
@harnish-elastic
elastic-package check
ed750c3
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @harnish-elastic

ritalwar
ritalwar approved these changes Jan 22, 2024
View reviewed changes
Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harnish-elastic harnish-elastic merged commit bd2ffaf into elastic:main Jan 22, 2024
3 checks passed
@elasticmachine
Copy link

Package activemq - 0.14.2 containing this change is available at https://epr.elastic.co/search?package=activemq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ritalwar ritalwar ritalwar approved these changes

@niraj-elastic niraj-elastic niraj-elastic approved these changes

Assignees

@harnish-elastic harnish-elastic

Labels
bugfix Integration:ActiveMQ
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[O11y][ActiveMQ] Conflicts in host.ip field
4 participants
@harnish-elastic @elasticmachine @ritalwar @niraj-elastic