Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pleasant Password Server] Initial Integration of PPS #8951

Merged
merged 17 commits into from
Feb 6, 2024
Merged

[Pleasant Password Server] Initial Integration of PPS #8951

merged 17 commits into from
Feb 6, 2024

Conversation

WildDogOne
Copy link
Contributor

@WildDogOne WildDogOne commented Jan 23, 2024 •
edited
Loading

Type of Change

  • Enhancement

Proposed commit message

We need an integration for the Pleasant Password Server.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Fix testing with v8.0
  • Optimize Logo
  • Go through ECS to check if everything is extracted as it should be

How to test this PR locally

Logs are in the PR, can be tested via Elastic Package

@WildDogOne
Copy link
Contributor Author

A little question about the structure, I have called the integration Pleasant Password Server, but the folder is pps because it's an often enough seen abbreviation for it. I can also change it, no problem

@jamiehynds jamiehynds requested a review from a team January 24, 2024 14:50
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@jamiehynds jamiehynds requested a review from a team January 26, 2024 10:20
WildDogOne and others added 5 commits January 29, 2024 09:46
@WildDogOne @efd6
Update packages/pps/changelog.yml
61b9dee 
Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@WildDogOne @efd6
Update packages/pps/data_stream/log/elasticsearch/ingest_pipeline/def…
b81ac57 
…ault.yml

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@WildDogOne @efd6
Update packages/pps/data_stream/log/elasticsearch/ingest_pipeline/def…
197101b 
…ault.yml

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@WildDogOne
added event original to testing
c3b11d0
@efd6
Merge branch 'main' into pps
49bb7b7
@efd6
Copy link
Contributor

efd6 commented Jan 30, 2024

/test

efd6
efd6 reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final nit then LGTM. Would you mind adding final newlines to the test config files.

efd6
efd6 reviewed Jan 30, 2024
View reviewed changes
packages/pps/manifest.yml Outdated Show resolved Hide resolved
@efd6
Copy link
Contributor

efd6 commented Jan 31, 2024

/test

@efd6
Copy link
Contributor

efd6 commented Jan 31, 2024

/test

@WildDogOne
Copy link
Contributor Author

Final nit then LGTM. Would you mind adding final newlines to the test config files.

If I understood correctly, you mean the test-*-config.yml. I have added CRLFs.

@efd6
Copy link
Contributor

efd6 commented Feb 6, 2024

/test

@efd6
fix log input tests
ce85055 
The log input requires new-line terminated logs.
@efd6
Copy link
Contributor

efd6 commented Feb 6, 2024

/test

@efd6
Copy link
Contributor

efd6 commented Feb 6, 2024

/test

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions

64.2% 64.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

@WildDogOne
Copy link
Contributor Author

Quality Gate failed Quality Gate failed

Failed conditions

64.2% 64.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

wouldn't it be nice to see what the issues are?
maybe I could then fix that

@efd6 efd6 merged commit 96dfcdc into elastic:main Feb 6, 2024
4 of 5 checks passed
@elasticmachine
Copy link

Package pps - 0.0.1 containing this change is available at https://epr.elastic.co/search?package=pps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
Community New Integration Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@WildDogOne @elasticmachine @efd6 @jamiehynds