Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proofpoint_tap] Add error.message ECS field mapping #8953

Merged
merged 3 commits into from Jan 24, 2024

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Jan 23, 2024

Proposed commit message

  • Add the error.message field to the ECS mappings
  • When not explicitly mapped in ecs.yml, error.message will assume a default type of keyword which conflicts with the ECS-defined type of match_only_text.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

- Add the error.message field to the ECS mappings
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@taylor-swanson taylor-swanson marked this pull request as ready for review January 23, 2024 22:23
@taylor-swanson taylor-swanson requested a review from a team as a code owner January 23, 2024 22:23
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you add background of the issue in the commit message for external readers.

@taylor-swanson taylor-swanson requested a review from a team as a code owner January 24, 2024 14:08
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @taylor-swanson

@taylor-swanson taylor-swanson merged commit 9a36183 into elastic:main Jan 24, 2024
3 checks passed
@taylor-swanson taylor-swanson deleted the bugfix/ecs-error-message branch January 24, 2024 14:23
@elasticmachine
Copy link

Package proofpoint_tap - 1.16.2 containing this change is available at https://epr.elastic.co/search?package=proofpoint_tap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration:Proofpoint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants