Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make etcd integration package GA #8955

Merged
merged 3 commits into from Jan 29, 2024
Merged

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Jan 24, 2024

  • Enhancement

Proposed commit message

Make ETCD Integration package GA.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Automated Tests / Manual Tests guidelines
  • Timeduration guidelines
  • Field mapping guidelines
  • Document quality check
  • Kibana dashboard guidelines
  • TSDB enablementt
  • SDHs check
  • Enhacement Requests check
  • Publish GA checklist summary

How to test this PR locally

Related issues

Screenshots

image

This was referenced Jan 24, 2024
@agithomas agithomas marked this pull request as ready for review January 24, 2024 09:15
@agithomas agithomas requested a review from a team as a code owner January 24, 2024 09:15
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is my observations on the documentation,

  1. Can we have all etcd reference in lowercase?
  2. As we have the metrics dataset which supports V3. Just a thought is it okay to change the title to metrics (v3) in the document?
Screenshot 2024-01-24 at 3 16 43 PM

@agithomas
Copy link
Contributor Author

  1. Can we have all etcd reference in lowercase?

Sure , will do that.

@agithomas
Copy link
Contributor Author

2. As we have the metrics dataset which supports V3. Just a thought is it okay to change the title to metrics (v3) in the document?

I think, this would lead to more confusions that use. metrics is the name of the dataset. If we make it metrics v3, it would be more confusing as there won't be any reference towards what metrics v3 means.

@agithomas agithomas changed the title Make ETCD GA Make etcd integration package GA Jan 24, 2024
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link

💚 Build Succeeded

History

@agithomas agithomas merged commit 5a741f3 into elastic:main Jan 29, 2024
3 checks passed
@elasticmachine
Copy link

Package etcd - 1.0.0 containing this change is available at https://epr.elastic.co/search?package=etcd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants