Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[o365] Add error.message ECS field mapping #8964

Merged
merged 2 commits into from Jan 25, 2024
Merged

[o365] Add error.message ECS field mapping #8964

merged 2 commits into from Jan 25, 2024

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Jan 24, 2024 •
edited

Proposed commit message

  • Add the error.message field to the ECS mappings
  • When not explicitly mapped in ecs.yml, error.message will assume a default type of keyword which conflicts with the ECS-defined type of match_only_text.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@taylor-swanson
[o365] Add error.message ECS field mapping
3247dbd 
- Add the error.message field to the ECS mappings
- When not explicitly mapped in ecs.yml, error.message will assume a default type of keyword which conflicts with the ECS-defined type of match_only_text.
@taylor-swanson taylor-swanson added bug Something isn't working Integration:o365 labels Jan 24, 2024
@taylor-swanson taylor-swanson self-assigned this Jan 24, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @taylor-swanson

@taylor-swanson taylor-swanson marked this pull request as ready for review January 24, 2024 16:24
@taylor-swanson taylor-swanson requested a review from a team as a code owner January 24, 2024 16:24
@taylor-swanson taylor-swanson added the Team:Security-Service Integrations Security Service Integrations Team label Jan 24, 2024
@taylor-swanson taylor-swanson merged commit 42da1a0 into elastic:main Jan 25, 2024
3 checks passed
@taylor-swanson taylor-swanson deleted the bugfix/o365-ecs-error-message branch January 25, 2024 14:08
@elasticmachine
Copy link

Package o365 - 2.1.2 containing this change is available at https://epr.elastic.co/search?package=o365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels
bug Something isn't working Integration:o365 Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taylor-swanson @elasticmachine @efd6