Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cisco_ios] Fix time zone configuration handling #9000

Merged
merged 3 commits into from
Jan 31, 2024
Merged

[cisco_ios] Fix time zone configuration handling #9000

merged 3 commits into from
Jan 31, 2024

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Jan 29, 2024 •
edited
Loading

Proposed commit message

  • Fixed issue where tz_offset would not apply if log has no time zone.
  • Simplified time zone processors down to one script processor
  • Add pipeline test to test case where tz_offset is provided and log has no time zone.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

cd packages/cisco_ios
elastic-package test

Related issues

@taylor-swanson
[cisco_ios] Fix time zone configuration handling
7b0e0e0 
- Fixed issue where tz_offset would not apply if log has no time zone.
- Simplified time zone processors down to one script processor
- Add pipeline test to test case where tz_offset is provided and log has no time zone.
@taylor-swanson taylor-swanson added bug Something isn't working Integration:CiscoIOS Cisco IOS Team:Security-Deployment and Devices Deployment and Devices Security team labels Jan 29, 2024
@taylor-swanson taylor-swanson self-assigned this Jan 29, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@taylor-swanson taylor-swanson marked this pull request as ready for review January 29, 2024 18:10
@taylor-swanson taylor-swanson requested a review from a team as a code owner January 29, 2024 18:10
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @taylor-swanson

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% 100.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@taylor-swanson taylor-swanson merged commit ac849de into main Jan 31, 2024
5 checks passed
@taylor-swanson taylor-swanson deleted the bug/cisco-ios-timezone branch January 31, 2024 20:29
@elasticmachine
Copy link

Package cisco_ios - 1.24.2 containing this change is available at https://epr.elastic.co/search?package=cisco_ios

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@taylor-swanson taylor-swanson

Labels
bug Something isn't working Integration:CiscoIOS Cisco IOS Team:Security-Deployment and Devices Deployment and Devices Security team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cisco_ios] Setting time zone configuration has no affect on logs with no time zone
3 participants
@taylor-swanson @elasticmachine @andrewkroh