Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

network_traffic: add notice for deprecation of map_to_ecs behaviour #9031

Merged
merged 1 commit into from Feb 1, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Feb 1, 2024

Proposed commit message

Add notice of significance, links to instructions for how to migrate legacy data and to the timeline for behaviour retirement.

The option is changed from show_user:false to show_user:true to avoid the leopard in the cellar problem.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:Network Packet Capture Team:Security-Service Integrations Security Service Integrations Team Team:Security-Linux Platform Linux Platform Security team labels Feb 1, 2024
@efd6 efd6 self-assigned this Feb 1, 2024
Add notice of significance, links to instructions for how to migrate legacy data
and to the timeline for behaviour retirement.

The option is changed from show_user:false to show_user:true to avoid the leopard
in the cellar problem.
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @efd6

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@efd6 efd6 marked this pull request as ready for review February 1, 2024 04:53
@efd6 efd6 requested a review from a team as a code owner February 1, 2024 04:53
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine
Copy link

Pinging @elastic/sec-linux-platform (Team:Security-Linux Platform)

@efd6 efd6 merged commit 24edad8 into elastic:main Feb 1, 2024
5 checks passed
@elasticmachine
Copy link

Package network_traffic - 1.30.0 containing this change is available at https://epr.elastic.co/search?package=network_traffic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:Network Packet Capture Team:Security-Linux Platform Linux Platform Security team Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants