Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[akamai] add api emulator for realistic testing #9042

Merged
merged 2 commits into from Feb 8, 2024

Conversation

andrewkroh
Copy link
Member

@andrewkroh andrewkroh commented Feb 2, 2024

Proposed commit message

This simulates the Akamai SIEM API. It provides realistic validation of request signatures. It emulates the time and offset based queries by simulating a world in which a new event happens every 5 minutes. The offset cursor is simply the unix time in sec of the last returned event.

This is a reproducer for the issues described in #9038. Those issues only occur when the tests in this changeset run on Elastic Agent < 8.11.0.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@andrewkroh andrewkroh force-pushed the akamai/feature/emulator-test branch 2 times, most recently from ef0d1d3 to 7daa998 Compare February 2, 2024 15:09
This simulates the Akamai SIEM API. It provides realistic validation of
request signatures. It emulates the time and offset based queries by
simulating a world in which a new event happens every 5 minutes. The
offset cursor is simply the unix time in sec of the last returned event.

This is a reproducer for the issues described in elastic#9038. Those issues
only occur on Elastic Agent < 8.11.0.
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

@andrewkroh andrewkroh marked this pull request as ready for review February 2, 2024 15:44
@andrewkroh andrewkroh requested a review from a team as a code owner February 2, 2024 15:44
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if we could have the emulator code in this repo and have it reviewed as well (I looked at it and it seems fine).

@andrewkroh
Copy link
Member Author

It would be nice if we could have the emulator code in this repo and have it reviewed as well (I looked at it and it seems fine).

This was something I was debating with myself. I was thinking that perhaps it should be in some external elastic repo where we have CI and linting running specifically for Go code plus using our normal code review process.

@andrewkroh andrewkroh merged commit c048a13 into elastic:main Feb 8, 2024
5 checks passed
@elasticmachine
Copy link

Package akamai - 2.22.0 containing this change is available at https://epr.elastic.co/search?package=akamai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants