Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

infoblox_bloxone_ddi: map dns fields to ecs #9062

Merged
merged 1 commit into from Feb 9, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Feb 6, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:infoblox_bloxone_ddi Infoblox BloxOne DDI (DNS, DHCP, IP management) Team:Security-Service Integrations Security Service Integrations Team labels Feb 6, 2024
@efd6 efd6 self-assigned this Feb 6, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

Package infoblox_bloxone_ddi 👍(2) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
dns_config 1394.7 1098.9 -295.8 (-21.21%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

Copy link

@efd6 efd6 marked this pull request as ready for review February 6, 2024 07:14
@efd6 efd6 requested a review from a team as a code owner February 6, 2024 07:14
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@chrisberkhout chrisberkhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@chrisberkhout
Copy link
Contributor

I was concerned that there would be a problem with having a non-leaf-node array, since that had come up for me earlier. I thought it might not show in the pipeline tests, so I added a case to the system test, and also modified the pipeline to add the answers object twice. But there were no problems indexing that.

I think it didn't work for me in the past because, for example, when using threat.indicator.url.*, I was getting definitions for the fields by explicitly importing subfields like threat.indicator.url.full without ever having threat.indicator.url explicitly defined as a group, or I was relying on dynamic mappings to get threat.indicator.url.full which also don't define the parent group.

@efd6 efd6 merged commit cf972ab into elastic:main Feb 9, 2024
5 checks passed
@efd6
Copy link
Contributor Author

efd6 commented Feb 11, 2024

I think it didn't work for me in the past because, for example, when using threat.indicator.url.*, I was getting definitions for the fields by explicitly importing subfields like threat.indicator.url.full without ever having threat.indicator.url explicitly defined as a group, or I was relying on dynamic mappings to get threat.indicator.url.full which also don't define the parent group.

Yes, this was the behaviour I was seeing. It is a little confusing.

@elasticmachine
Copy link

Package infoblox_bloxone_ddi - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=infoblox_bloxone_ddi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Integration:infoblox_bloxone_ddi Infoblox BloxOne DDI (DNS, DHCP, IP management) Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Infoblox BloxOne DDI] DNS Data Records Not Populating ECS Fields
3 participants