Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[O11y][Spring Boot] Update README to use documentation guidelines. #9070

Conversation

harnish-elastic
Copy link
Contributor

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@harnish-elastic harnish-elastic added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 6, 2024
@harnish-elastic harnish-elastic self-assigned this Feb 6, 2024
@elasticmachine
Copy link

elasticmachine commented Feb 6, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@harnish-elastic harnish-elastic marked this pull request as ready for review February 7, 2024 04:57
@harnish-elastic harnish-elastic requested a review from a team as a code owner February 7, 2024 04:57
Copy link
Collaborator

@kush-elastic kush-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@harnish-elastic harnish-elastic force-pushed the spring_boot-update-readme-as-per-guidelines branch from 9e905ed to ed267ee Compare February 7, 2024 12:03
Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after comments are integrated.

packages/spring_boot/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/spring_boot/_dev/build/docs/README.md Outdated Show resolved Hide resolved
packages/spring_boot/_dev/build/docs/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/spring_boot/docs/README.md Outdated Show resolved Hide resolved
packages/spring_boot/docs/README.md Outdated Show resolved Hide resolved
packages/spring_boot/docs/README.md Outdated Show resolved Hide resolved
packages/spring_boot/docs/README.md Outdated Show resolved Hide resolved
packages/spring_boot/docs/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@devamanv devamanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

	packages/spring_boot/manifest.yml
@harnish-elastic harnish-elastic enabled auto-merge (squash) February 13, 2024 09:08
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @harnish-elastic

@harnish-elastic harnish-elastic merged commit ba8c747 into elastic:main Feb 13, 2024
4 checks passed
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link

Package spring_boot - 1.3.1 containing this change is available at https://epr.elastic.co/search?package=spring_boot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apply the Integrations doc template to Spring Boot
5 participants