[cisco_ios] Improve parsing groks to better handle generic messages #9102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The header of the log is now parsed first. A second grok runs afterwards which will look for the Cisco-mnemonic prefix for the message portion of log. If it is not found, the message will be placed into a temporary field until after Cisco messages have been processed, where it will then be placed back into the 'message' field. - Add hit count asserts to system tests - Add newlines to sample logs so last entries are not missed by logfile system test
taylor-swanson
added
enhancement
taylor-swanson
commented
Feb 8, 2024
Comment on lines
-58
to
-62
| on_failure: | ||
| - append: | ||
| field: error.message | ||
| value: |- | ||
| Processor "{{ _ingest.on_failure_processor_type }}" with tag "{{ _ingest.on_failure_processor_tag }}" in pipeline "{{ _ingest.on_failure_pipeline }}" failed with message "{{ _ingest.on_failure_message }}" |
There was a problem hiding this comment.
I'm pretty sure this is made redundant by the on_failure handler for the pipeline.
4 tasks
🚀 Benchmarks reportTo see the full report comment with |
|
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
|
/test benchmark fullreport |
gogochan
reviewed
Feb 12, 2024
packages/cisco_ios/data_stream/log/elasticsearch/ingest_pipeline/default.yml
Show resolved
Hide resolved
4 tasks
gogochan
approved these changes
Mar 4, 2024
💚 Build Succeeded
History
|
|
100.0% Coverage on New Code
0.0% Duplication on New Code
|
Package cisco_ios - 1.26.1 containing this change is available at https://epr.elastic.co/search?package=cisco_ios |
gizas
pushed a commit
that referenced
this pull request
Mar 13, 2024
…9102) - The header of the log is now parsed first. A second grok runs afterwards which will look for the Cisco-mnemonic prefix for the message portion of log. If it is not found, the message will be placed into a temporary field until after Cisco messages have been processed, where it will then be placed back into the 'message' field. - Add hit count asserts to system tests - Add newlines to sample logs so last entries are not missed by logfile system test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.How to test this PR locally
Related issues