New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AWS] Add MSK integration #9133
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions to consider for the dashboard
- There seems to be a floating icon (Grammerly?) captured in the screenshot
- Consider changing the metrics to the new Lens metric, stacked vertically. You could increase the width of the top chart to make up for lost horizontal space
- Adding panel titles would make it much easier to scan for the information I'm looking for. And/or you could add markdown panels in between the first and second row and second and third row with a larger title that describes both visualizations.
🚀 Benchmarks reportPackage
|
Data stream | Previous EPS | New EPS | Diff (%) | Result |
---|---|---|---|---|
route53_public_logs |
13513.51 | 10869.57 | -2643.94 (-19.57%) | 💔 |
waf |
5747.13 | 4255.32 | -1491.81 (-25.96%) | 💔 |
To see the full report comment with /test benchmark fullreport
@drewdaemon Thank you so much for your review!! We are planning on enhancing the dashboard later in a separate PR anyway so Im gonna address your comment then! Thanks again!! (I did crop the screenshot so no Grammarly logo there 😬 ) |
💚 Build Succeeded
History
|
Quality Gate failedFailed conditions66.7% Coverage on New Code (required ≥ 80%) |
Package aws - 2.13.0 containing this change is available at https://epr.elastic.co/search?package=aws |
Proposed commit message
This PR is to add a new integration for Amazon MSK.
Metrics available for MSK serverless cluster: https://docs.aws.amazon.com/msk/latest/developerguide/serverless-monitoring.html
Metrics available for general MSK cluster: https://docs.aws.amazon.com/msk/latest/developerguide/metrics-details.html
This integration collects all metrics available at the DEFAULT monitoring level and the basic dashboard only uses metrics available for MSK serverless clusters.
Checklist
changelog.yml
file.Related issues
Screenshots