Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cisco_ftd] Null handling and other clean-up #9141

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

chrisberkhout
Copy link
Contributor

Proposed commit message

[cisco_ftd] Null handling and other clean-up (#)

- Remove redundant null-safe access to ctx.
- Add space around the conditional operator.
- Remove trailing whitespace.
- Combine 'not null and is value' checks.
- Remove redundant null-safe accesses.
- Combine 'is null or not value' checks.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@chrisberkhout chrisberkhout requested a review from a team as a code owner February 13, 2024 17:51
@chrisberkhout chrisberkhout self-assigned this Feb 13, 2024
@chrisberkhout chrisberkhout added Integration:CiscoFTD Cisco FTD Firepower Threat Defense bugfix Team:Security-Deployment and Devices Deployment and Devices Security team labels Feb 13, 2024
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @chrisberkhout

Copy link

Quality Gate failed Quality Gate failed

Failed conditions

37.5% 37.5% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@chrisberkhout chrisberkhout merged commit 6d4430a into elastic:main Feb 13, 2024
4 of 5 checks passed
@chrisberkhout chrisberkhout deleted the cisco_ftd-nulls-clean-up branch February 13, 2024 18:36
@elasticmachine
Copy link

Package cisco_ftd - 3.1.2 containing this change is available at https://epr.elastic.co/search?package=cisco_ftd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Integration:CiscoFTD Cisco FTD Firepower Threat Defense Team:Security-Deployment and Devices Deployment and Devices Security team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants