sophos_central: ensure from_date parameter is within bounds #9143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
Integration:Sophos
bugfix
Team:Security-Service Integrations
efd6
force-pushed
the
9140-sophos_central
branch
from
a58dbcd
to
a79f325
Compare
The Sophos Central API requires that request are within the last 24 hours, so clamp the from_date parameter to within this constraint to prevent invalid user input or invalid cursors from causing request failure.
efd6
force-pushed
the
9140-sophos_central
branch
from
a79f325
to
24ef594
Compare
|
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
cc @efd6 |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
efd6
commented
Feb 14, 2024
| @@ -25,8 +25,8 @@ request.transforms: | |||
| value: {{tenant_id}} | |||
| - set: | |||
| target: url.params.from_date | |||
| value: '[[.cursor.from_date]]' | |||
| default: '[[(now (parseDuration "-{{initial_interval}}")).Unix]]' | |||
| value: '[[max .cursor.from_date ((now).Add (parseDuration "-23h59m")).Unix]]' | |||
There was a problem hiding this comment.
Choose 23h59m to avoid failure due to skew between now and when the request arrives at the endpoint.
|
Package sophos_central - 1.13.2 containing this change is available at https://epr.elastic.co/search?package=sophos_central |
gizas
pushed a commit
that referenced
this pull request
Mar 13, 2024
The Sophos Central API requires that request are within the last 24 hours, so clamp the from_date parameter to within this constraint to prevent invalid user input or invalid cursors from causing request failure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
The Sophos Central API requires that request are within the last 24 hours, so clamp the from_date parameter to within this constraint to prevent invalid user input or invalid cursors from causing request failure.
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots