Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tenable_sc] Clean up null handling #9152

Merged
merged 3 commits into from Feb 19, 2024

Conversation

chrisberkhout
Copy link
Contributor

Proposed commit message

[tenable_sc] Clean up null handling (#)

- Check for null before > operator.
- Combine 'is null or not contains' checks.
- Combine 'not null and is/not value' checks.
- Add not null check to 'not value' checks.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@chrisberkhout chrisberkhout self-assigned this Feb 14, 2024
@chrisberkhout chrisberkhout requested a review from a team as a code owner February 14, 2024 16:30
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @chrisberkhout

Copy link

@chrisberkhout chrisberkhout merged commit 083a3bc into elastic:main Feb 19, 2024
5 checks passed
@chrisberkhout chrisberkhout deleted the tenable_sc-null-handling branch February 19, 2024 11:08
@elasticmachine
Copy link

Package tenable_sc - 1.20.2 containing this change is available at https://epr.elastic.co/search?package=tenable_sc

gizas pushed a commit that referenced this pull request Mar 13, 2024
- Check for null before > operator.
- Combine 'is null or not contains' checks.
- Combine 'not null and is/not value' checks.
- Add not null check to 'not value' checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants