Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proofpoint_tap] Clean up null handling #9153

Merged

Conversation

chrisberkhout
Copy link
Contributor

Proposed commit message

[proofpoint_tap] Clean up null handling (#)

- Combine 'is null or not contains' checks.
- Combine 'not null and is/not value' checks.
- Remove redundant null-safe operator.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@chrisberkhout chrisberkhout self-assigned this Feb 14, 2024
@chrisberkhout chrisberkhout requested a review from a team as a code owner February 14, 2024 16:54
@elasticmachine
Copy link

🚀 Benchmarks report

Package proofpoint_tap 👍(0) 💚(3) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
message_delivered 2923.98 2331 -592.98 (-20.28%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

cc @chrisberkhout

Copy link

@chrisberkhout chrisberkhout merged commit 87e6e91 into elastic:main Feb 15, 2024
5 checks passed
@chrisberkhout chrisberkhout deleted the proofpoint_tap-null-handling branch February 15, 2024 08:16
@elasticmachine
Copy link

Package proofpoint_tap - 1.16.3 containing this change is available at https://epr.elastic.co/search?package=proofpoint_tap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants