Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[panw_cortex_xdr] Clean up null handling #9175

Merged

Conversation

chrisberkhout
Copy link
Contributor

@chrisberkhout chrisberkhout commented Feb 15, 2024

Proposed commit message

[panw_cortex_xdr] Clean up null handling (#)

- Combine 'not null and is/not value' checks.
- Remove redundant null-safe access to ctx.
- Remove redundant null-safe operator.
- Remove redundant quotes and brackets.
- Combine 'is null or not contains' checks.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@chrisberkhout chrisberkhout self-assigned this Feb 15, 2024
@chrisberkhout chrisberkhout requested a review from a team as a code owner February 15, 2024 15:51
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @chrisberkhout

Copy link

Quality Gate failed Quality Gate failed

Failed conditions

58.3% 58.3% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@chrisberkhout chrisberkhout merged commit 1481c92 into elastic:main Feb 21, 2024
4 of 5 checks passed
@chrisberkhout chrisberkhout deleted the panw_cortex_xdr-null-handling branch February 21, 2024 08:28
@elasticmachine
Copy link

Package panw_cortex_xdr - 1.24.2 containing this change is available at https://epr.elastic.co/search?package=panw_cortex_xdr

gizas pushed a commit that referenced this pull request Mar 13, 2024
- Combine 'not null and is/not value' checks.
- Remove redundant null-safe access to ctx.
- Remove redundant null-safe operator.
- Remove redundant quotes and brackets.
- Combine 'is null or not contains' checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants