Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jamf_compliance_reporter] Clean up null handling, other checks, scripting #9179

Merged
merged 4 commits into from
Feb 22, 2024
Merged

[jamf_compliance_reporter] Clean up null handling, other checks, scripting #9179

merged 4 commits into from
Feb 22, 2024

Conversation

chrisberkhout
Copy link
Contributor

@chrisberkhout chrisberkhout commented Feb 15, 2024 •
edited
Loading

Proposed commit message

[jamf_compliance_reporter] Clean up null handling, other checks, scripting (#)

- Combine 'not null and is/not value' checks.
- Remove redundant null-safe operator.
- Add 'not null' check to 'not value' checks.
- Correct date conversion conditions to check source values.
- Add 'not null' check before .entrySet().
- Avoid trying to cast null to long/int.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Related issues

@chrisberkhout chrisberkhout self-assigned this Feb 15, 2024
@chrisberkhout chrisberkhout requested a review from a team as a code owner February 15, 2024 17:46
@chrisberkhout chrisberkhout mentioned this pull request Feb 15, 2024
Open
39 tasks
@chrisberkhout chrisberkhout changed the title [jamf_compliance_reporter] Clean up null handling, other checks and scripting [jamf_compliance_reporter] Clean up null handling, other checks, scripting Feb 15, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@chrisberkhout @efd6
Update packages/jamf_compliance_reporter/data_stream/log/elasticsearc…
da33145 
…h/ingest_pipeline/pipeline_app_metrics.yml

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @chrisberkhout

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
98.2% 98.2% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@chrisberkhout chrisberkhout merged commit 1cfde6b into elastic:main Feb 22, 2024
5 checks passed
@chrisberkhout chrisberkhout deleted the jamf_compliance_reporter-null-handling branch February 22, 2024 06:48
@elasticmachine
Copy link

Package jamf_compliance_reporter - 1.11.2 containing this change is available at https://epr.elastic.co/search?package=jamf_compliance_reporter

gizas pushed a commit that referenced this pull request Mar 13, 2024
@chrisberkhout @efd6 @gizas
[jamf_compliance_reporter] Clean up null handling, other checks, scri…
017813f 
…pting (#9179)

- Combine 'not null and is/not value' checks.
- Remove redundant null-safe operator.
- Add 'not null' check to 'not value' checks.
- Correct date conversion conditions to check source values.
- Add 'not null' check before .entrySet().
- Avoid trying to cast null to long/int.

---------

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

@chrisberkhout chrisberkhout

Labels
bugfix Integration:JAMF_Compliance_Reporter Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@chrisberkhout @elasticmachine @efd6