Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MySQL] Added missing dimensions to the performance datastream #9219

Merged
merged 2 commits into from Feb 23, 2024

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Feb 22, 2024

  • Bug

Proposed commit message

Added missing dimension, table_io_waits.index.name, to the performance datastream, to resolve missing data problem

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • elastic-package build
  • elastic-package stack up -v -d --services package-registry

How to test this PR locally

Manual verification

Related issues

Screenshots

@agithomas agithomas marked this pull request as ready for review February 22, 2024 06:37
@agithomas agithomas requested a review from a team as a code owner February 22, 2024 06:37
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@ritalwar
Copy link
Contributor

Can you please add the link to the issue solved by this PR?
Also, could we explain in more detail in description why the index name should be a dimension?

Copy link
Contributor

@ritalwar ritalwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@agithomas agithomas merged commit 1c7fd47 into elastic:main Feb 23, 2024
5 checks passed
@elasticmachine
Copy link

Package mysql - 1.18.1 containing this change is available at https://epr.elastic.co/search?package=mysql

gizas pushed a commit that referenced this pull request Mar 13, 2024
* Added missing dimensions for MySQL performance datastream
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants