Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use decode_xml_wineventlog in windows Splunk inputs #923

Merged
merged 1 commit into from
Apr 22, 2021
Merged

Use decode_xml_wineventlog in windows Splunk inputs #923

merged 1 commit into from
Apr 22, 2021

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Apr 20, 2021

What does this PR do?

Uses decode_xml_wineventlog processor instead of decode_xml

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.

@marc-gr marc-gr requested a review from leehinman April 20, 2021 09:24
@elasticmachine
Copy link

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@elasticmachine
Copy link

elasticmachine commented Apr 20, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Branch indexing

  • Start Time: 2021-04-21T22:28:20.467+0000

  • Duration: 43 min 46 sec

  • Commit: f17bac7

Test stats 🧪

Test Results
Failed 0
Passed 1926
Skipped 3
Total 1929

Trends 🧪

Image of Build Times

Image of Tests

leehinman
leehinman approved these changes Apr 20, 2021
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marc-gr marc-gr merged commit 88b02e1 into elastic:master Apr 22, 2021
@marc-gr marc-gr deleted the splunk-change-processor-windows branch April 22, 2021 08:29
james-elastic pushed a commit to james-elastic/integrations that referenced this pull request Jun 30, 2021
@marc-gr @james-elastic
Use decode_xml_wineventlog in windows Splunk inputs (elastic#923)
846fbc0
eyalkraft pushed a commit to build-security/integrations that referenced this pull request Mar 30, 2022
@marc-gr
Use decode_xml_wineventlog in windows Splunk inputs (elastic#923)
d10ecc6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leehinman leehinman leehinman approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marc-gr @elasticmachine @leehinman