Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CISA KEVs] New Integration - CISA Known Exploited Vulnerabilities Tracking #9240

Merged
merged 23 commits into from
Mar 14, 2024

Conversation

nicpenning
Copy link
Contributor

@nicpenning nicpenning commented Feb 24, 2024

  • Enhancement

  • WHAT: CISA Known Exploited Vulnerabilities at glance in the stack. Can also be used for enriching other datasets that contain vulnerability information and more specifically, CVEs.

  • WHY: This will allow analysts to see the current KEVs in Elastic and/or correlate those with other vulnerability information ingested into the stack.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

Add a checklist of things that are required to be reviewed in order to have the PR approved

- [ ] It would be great to use the CISA logo but I think Elastic needs to request permission to use it.

  • Dashboard screenshot

Screenshots

image

image

Dashboard

@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@jamiehynds jamiehynds requested a review from a team February 27, 2024 21:46
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change here very large, solely in the test expectations. Would it be possible, without loss of integrity, to reduce the size of this somehow?

packages/cisa_kevs/LICENSE.txt Outdated Show resolved Hide resolved
@efd6
Copy link
Contributor

efd6 commented Feb 29, 2024

/test

@nicpenning
Copy link
Contributor Author

nicpenning commented Feb 29, 2024

The change here very large, solely in the test expectations. Would it be possible, without loss of integrity, to reduce the size of this somehow?

👋 Hello, we meet again!

I can try to see what I can do for the size.

Are referring to file size, number of commits or something else?

A screenshot or reference to what is large will be great!

For example, I can reduce a couple of the files for testing such as these:
image

Today I use the entire CISA KEV library for the test. But if we want to bring it down to around 100 items instead of the 1000+, I can easily do that and not feel like we lose much on the testing.

If this is what you would like to see sized down, I have the changes ready to commit. The new sizes would be around 1,204 and 3,504 lines respectively.

@nicpenning
Copy link
Contributor Author

@jamiehynds - Can you request from CISA if we can use their logo for this integration?

https://www.cisa.gov/intellectual-property-policy

@jamiehynds
Copy link

jamiehynds commented Feb 29, 2024

@jamiehynds - Can you request from CISA if we can use their logo for this integration?

https://www.cisa.gov/intellectual-property-policy

Hey @nicpenning, I've just applied but expect it might take some time to work though. We can likely go ahead without a logo for now, and can add it if/when we get approval.

Thanks for yet another great contribution :)

@nicpenning
Copy link
Contributor Author

nicpenning commented Mar 1, 2024

I have a hunch buildkite will be unhappy since I used a new version of the stack. (8.12)

Build kite might not be able to test newer versions still?

@jamiehynds
Copy link

@nicpenning @efd6 CISA have confirmed that we are fine to proceed with the integration, however they cannot authorise us to use their logo and we'll therefore need to stick with no logo. We have a generic logo we use for Netflow and File Integrity Monitoring and can use for this package too.

@nicpenning
Copy link
Contributor Author

Thanks for the follow up! I can look at those integrations and logo and get it added.

@nicpenning
Copy link
Contributor Author

The change here very large, solely in the test expectations. Would it be possible, without loss of integrity, to reduce the size of this somehow?

A reduced the sample size so now were are down to about 6500 lines for everything.
image

@nicpenning
Copy link
Contributor Author

@nicpenning @efd6 CISA have confirmed that we are fine to proceed with the integration, however they cannot authorise us to use their logo and we'll therefore need to stick with no logo. We have a generic logo we use for Netflow and File Integrity Monitoring and can use for this package too.

I used the generic Logs one as it is pretty straight forward. Will that work? It is a "list".
image

@efd6
Copy link
Contributor

efd6 commented Mar 11, 2024

/test

nicpenning and others added 2 commits March 11, 2024 17:24
Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@efd6
Copy link
Contributor

efd6 commented Mar 13, 2024

/test

@efd6
Copy link
Contributor

efd6 commented Mar 13, 2024

/test

@efd6
Copy link
Contributor

efd6 commented Mar 13, 2024

/test

@efd6
Copy link
Contributor

efd6 commented Mar 13, 2024

/test

@efd6
Copy link
Contributor

efd6 commented Mar 13, 2024

/test

Copy link
Contributor Author

@nicpenning nicpenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6
Copy link
Contributor

efd6 commented Mar 13, 2024

/test

@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link

Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but waiting for @jamiehynds for decision on icon.

@jamiehynds
Copy link

LGTM but waiting for @jamiehynds for decision on icon.

@efd6 just commented on the icon discussion. No concerns on my end on list vs default icon, just as long as it's not CISA's logo.

@efd6 efd6 merged commit cebb64f into elastic:main Mar 14, 2024
5 checks passed
@nicpenning nicpenning deleted the cisa-kevs branch March 14, 2024 12:16
@nicpenning
Copy link
Contributor Author

Thanks team!! 🚀

@clement-fouque
Copy link

Nice one @nicpenning 👏 !

@nicpenning
Copy link
Contributor Author

Is there a timeline for how long it takes for this package to be placed in the registry for use to the masses?

@jamiehynds
Copy link

Is there a timeline for how long it takes for this package to be placed in the registry for use to the masses?

Hey @nicpenning - the package is generally published on the same day it's merged. We should see a notification appear within this PR to say it's available. I'll let you know either way as soon as it lands

@elasticmachine
Copy link

Package cisa_kevs - 0.1.0 containing this change is available at https://epr.elastic.co/search?package=cisa_kevs

@andrewkroh andrewkroh added the Integration:cisa_kevs CISA Known Exploited Vulnerabilities label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:cisa_kevs CISA Known Exploited Vulnerabilities New Integration Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants