[ti_crowdstrike] Add Mapping of Hash Sha1 type Indicator #9270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add offset in the config in case of unsuccessful requests. Add test data related to the hash sha1 type indicator in pipeline test.
kcreddy
reviewed
Mar 5, 2024
kcreddy
added
bugfix
Integration:TI Crowdstrike
Team:Security-Service Integrations
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Change the secret to false for token url.
|
/test |
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
|
100.0% Coverage on New Code
0.0% Duplication on New Code
|
Package ti_crowdstrike - 0.5.1 containing this change is available at https://epr.elastic.co/search?package=ti_crowdstrike |
1 similar comment
|
Package ti_crowdstrike - 0.5.1 containing this change is available at https://epr.elastic.co/search?package=ti_crowdstrike |
gizas
pushed a commit
that referenced
this pull request
Mar 13, 2024
* Add the mapping of hash sha1 type indicator. As per the API Documentation, Hash Sha1 type indicator is not mentioned in the Intel Responses but the users are getting those in the live responses hence adding the support for that. * Add the offset in the config in case of unsuccessful requests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
What does this PR do?
1. Add the mapping of hash sha1 type indicator.
As per the API Documentation, Hash Sha1 type indicator is not mentioned in the Intel Responses but the customer are getting those in the live responses (mentioned in SDH Issue) hence adding the support for that.
2. Add the offset in the config in case of unsuccessful requests.
Checklist
changelog.ymlfile.All changes
How to test this PR locally
Clone integrations repo.
Install the elastic package locally.
Start the elastic stack using the elastic package.
Move to integrations/packages/ti_crowdstrike directory.
Run the following command to run tests.
elastic-package test -vRelated issues
Automated Test
test_ti_crowdstrike-0.5.1.txt