Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

citrix_waf: relax header format constraints #9285

Merged
merged 1 commit into from Mar 26, 2024
Merged

citrix_waf: relax header format constraints #9285

merged 1 commit into from Mar 26, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 6, 2024

Proposed commit message

  • allow missing citrix header
  • allow syslog priority field
  • allow year-first date format in timestamp

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:CitrixWAF Citrix Web App Firewall integration Team:Security-Deployment and Devices Deployment and Devices Security team labels Mar 6, 2024
@efd6 efd6 self-assigned this Mar 6, 2024
@elasticmachine
Copy link

elasticmachine commented Mar 6, 2024 •
edited

🚀 Benchmarks report

Package citrix_waf 👍(0) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
log 1396.65 1161.44 -235.21 (-16.84%) 💔

To see the full report comment with /test benchmark fullreport

@efd6 efd6 force-pushed the 9266-citrix_waf branch 2 times, most recently from d9268c7 to f3eb312 Compare March 6, 2024 21:30
@efd6
citrix_waf: relax header format constraints
59902c5 
- allow missing citrix header
- allow syslog priority field
- allow year-first date format in timestamp
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% 100.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@efd6 efd6 marked this pull request as ready for review March 6, 2024 22:02
@efd6 efd6 requested a review from a team as a code owner March 6, 2024 22:03
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@efd6
Copy link
Contributor Author

efd6 commented Mar 6, 2024

@jamiehynds The owner label here disagrees with the label on the issue. Which is correct?

@jamiehynds
Copy link

@jamiehynds The owner label here disagrees with the label on the issue. Which is correct?

Given that Citrix WAF is an appliance that syslogs I think it lives with deployment and devices, but will let @norrietaylor or @narph confirm.

@narph
Copy link
Contributor

narph commented Mar 7, 2024

the team owner was probably wrongly assigned in #9266 but indeed Citrix WAF is currently owned by deployment and devices team.

@norrietaylor
Copy link
Member

Agreed @narph! Thanks for getting here first.

@efd6 efd6 enabled auto-merge (squash) March 7, 2024 22:52
@eriroley
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

taylor-swanson
taylor-swanson approved these changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@taylor-swanson taylor-swanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit 8dfbf01 into elastic:main Mar 26, 2024
5 checks passed
@elasticmachine
Copy link

Package citrix_waf - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=citrix_waf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taylor-swanson taylor-swanson taylor-swanson approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:CitrixWAF Citrix Web App Firewall integration Team:Security-Deployment and Devices Deployment and Devices Security team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Citrix Web App Firewall - v 1.13.2 - Grok Errirs
7 participants
@efd6 @elasticmachine @jamiehynds @narph @norrietaylor @eriroley @taylor-swanson