Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cisco_meraki] fix uri parts in log datastream #9310

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

bhapas
Copy link
Contributor

@bhapas bhapas commented Mar 8, 2024

Proposed commit message

Cisco Meraki integration (https://docs.elastic.co/en/integrations/cisco_meraki) not parsing url.original field into url.domain, url.path, and url.scheme as it was in Filebeat.

SO fixed this using uri_parts processor and registered_domain processor for domain part.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

elastic-package stack up -d -v && elastic-package test pipeline -v

@bhapas bhapas requested a review from a team as a code owner March 8, 2024 08:52
@bhapas bhapas self-assigned this Mar 8, 2024
@bhapas bhapas added bug Something isn't working Integration:Cisco Meraki bugfix Team:Security-Service Integrations Security Service Integrations Team labels Mar 8, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit. LGTM 👍🏼

…eline/urls.yml

Co-authored-by: Krishna Chaitanya Reddy Burri <krish.reddy91@gmail.com>
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @bhapas

Copy link

@bhapas bhapas merged commit bade243 into elastic:main Mar 8, 2024
5 checks passed
@elasticmachine
Copy link

Package cisco_meraki - 1.21.1 containing this change is available at https://epr.elastic.co/search?package=cisco_meraki

gizas pushed a commit that referenced this pull request Mar 13, 2024
* fix uri parts in log datastream

* Update packages/cisco_meraki/data_stream/log/elasticsearch/ingest_pipeline/urls.yml

Co-authored-by: Krishna Chaitanya Reddy Burri <krish.reddy91@gmail.com>

---------

Co-authored-by: Krishna Chaitanya Reddy Burri <krish.reddy91@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bugfix Integration:Cisco Meraki Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants