Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http_endpoint: allow user specified HTTP method #9311

Merged
merged 2 commits into from
Mar 28, 2024
Merged

http_endpoint: allow user specified HTTP method #9311

merged 2 commits into from
Mar 28, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 8, 2024 •
edited
Loading

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

Screenshot from 2024-03-08 20-05-43

@efd6 efd6 added enhancement New feature or request Integration:Custom HTTP Endpoint Team:Security-Scalability Security Integrations Scalability team labels Mar 8, 2024
@efd6 efd6 self-assigned this Mar 8, 2024
@efd6 efd6 marked this pull request as ready for review March 8, 2024 09:23
@efd6 efd6 requested a review from a team as a code owner March 8, 2024 09:23
@elasticmachine
Copy link

Pinging @elastic/security-scalability (Team:Security-Scalability)

@efd6 efd6 added Team:Security-Service Integrations Security Service Integrations Team and removed Team:Security-Scalability Security Integrations Scalability team labels Mar 26, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

kcreddy
kcreddy reviewed Mar 27, 2024
View reviewed changes
packages/http_endpoint/data_stream/generic/manifest.yml
@@ -6,6 +6,20 @@ streams:
title: Custom HTTP Endpoint Logs
template_path: http.yml.hbs
vars:
- name: method
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we take this variable method into input configuration?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed we should.

@efd6 efd6 requested a review from kcreddy March 27, 2024 20:37
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

kcreddy
kcreddy approved these changes Mar 28, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit c3425ce into elastic:main Mar 28, 2024
5 checks passed
@elasticmachine
Copy link

Package http_endpoint - 1.16.0 containing this change is available at https://epr.elastic.co/search?package=http_endpoint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:Custom HTTP Endpoint Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Custom HTTP Endpoint] Supporting PUT method
3 participants
@efd6 @elasticmachine @kcreddy