Re-enable secrets for packages disabled due to Kibana versions below … #9321
Conversation
🚀 Benchmarks reportTo see the full report comment with |
There was a problem hiding this comment.
@ritalwar I tried loading the integrations with default configs in 8.12.0 and 2 integrations (cockroachdb and prometheus) in 8.12.1 & I didn't face any errors loading the packages. LGTM for the changes !!
|
@ritalwar, some packages are marked as: |
packages/cockroachdb/changelog.yml
Outdated
| @@ -1,3 +1,8 @@ | |||
| - version: "1.9.0" | |||
| changes: | |||
| - description: Enable secrets with Kibana upgrade to 8.12, resolving errors. | |||
There was a problem hiding this comment.
The version should be 8.12.1 in changelog here.
There was a problem hiding this comment.
We're discussing offline about updating this changelog message for all packages, will adjust accordingly.
In version 8.12.0 of Kibana, the Fleet plugin was refactored, fixing how dynamic mappings for integrations are generated. However, this change caused mapping conflicts during data ingestion, impacting integrations like Prometheus and CockroachDB. The issue was resolved in version 8.12.1, therefore an upgrade to this version for these packages. Detailed information here. |
Ok, We are resolving the dynamic mapping issue in this PR as well? So it is only for prometheus type packages? |
Integrations using dynamic mappings would have this issue in 8.12 |
Should that be mixed with this work? This will disable secrets for someone running just 8.12.0. |
We're not resolving the dynamic mapping issue, it's already fixed in this PR and available from version 8.12.1. Due to system test failures in 8.12.0, we had to upgrade to 8.12.1. |
The CI/CD would fail for these packages if the version is 8.12. |
…egrations into re-enable-secret-below-8.10
💚 Build Succeeded
History
cc @ritalwar |
|
100.0% Coverage on New Code
0.0% Duplication on New Code
|
Package activemq - 1.2.0 containing this change is available at https://epr.elastic.co/search?package=activemq |
|
Package apache_tomcat - 1.4.0 containing this change is available at https://epr.elastic.co/search?package=apache_tomcat |
|
Package azure_app_service - 0.3.0 containing this change is available at https://epr.elastic.co/search?package=azure_app_service |
|
Package azure_billing - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=azure_billing |
|
Package azure_functions - 0.4.0 containing this change is available at https://epr.elastic.co/search?package=azure_functions |
|
Package cassandra - 1.12.0 containing this change is available at https://epr.elastic.co/search?package=cassandra |
|
Package ceph - 1.4.0 containing this change is available at https://epr.elastic.co/search?package=ceph |
|
Package citrix_adc - 1.4.0 containing this change is available at https://epr.elastic.co/search?package=citrix_adc |
|
Package cockroachdb - 1.9.0 containing this change is available at https://epr.elastic.co/search?package=cockroachdb |
|
Package golang - 1.4.0 containing this change is available at https://epr.elastic.co/search?package=golang |
|
Package kafka - 1.13.0 containing this change is available at https://epr.elastic.co/search?package=kafka |
|
Package kafka_log - 1.6.0 containing this change is available at https://epr.elastic.co/search?package=kafka_log |
|
Package mysql - 1.19.0 containing this change is available at https://epr.elastic.co/search?package=mysql |
|
Package nginx - 1.20.0 containing this change is available at https://epr.elastic.co/search?package=nginx |
|
Package oracle_weblogic - 1.5.0 containing this change is available at https://epr.elastic.co/search?package=oracle_weblogic |
|
Package postgresql - 1.19.0 containing this change is available at https://epr.elastic.co/search?package=postgresql |
|
Package prometheus - 1.15.0 containing this change is available at https://epr.elastic.co/search?package=prometheus |
|
Package prometheus_input - 0.4.0 containing this change is available at https://epr.elastic.co/search?package=prometheus_input |
|
Package rabbitmq - 1.13.0 containing this change is available at https://epr.elastic.co/search?package=rabbitmq |
|
Package salesforce - 0.14.0 containing this change is available at https://epr.elastic.co/search?package=salesforce |
|
Package spring_boot - 1.4.0 containing this change is available at https://epr.elastic.co/search?package=spring_boot |
|
Package websphere_application_server - 1.3.0 containing this change is available at https://epr.elastic.co/search?package=websphere_application_server |
#9321) * Re-enable secrets for packages disabled due to Kibana versions below 8.10 errors.
Proposed commit message
Restore the secret for packages that were disabled because of Kibana versions below 8.12, as they were causing errors.
Secrets were reverted for older stack version earlier in this PR - #9279
Now it is enabled only for stack 8.12 onwards.
For Prometheus and CockroachDB it is enabled for version 8.12.1 onwards, due to mapping conflicts resolved in the Fleet plugin.
Checklist
changelog.ymlfile.Related issues