Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

carbon_black_cloud: fix handling of network direction #9340

Merged
merged 3 commits into from
Mar 13, 2024
Merged

carbon_black_cloud: fix handling of network direction #9340

merged 3 commits into from
Mar 13, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 12, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added Integration:CarbonBlackCloud Carbon Black Cloud bugfix Team:Security-Service Integrations Security Service Integrations Team labels Mar 12, 2024
@efd6 efd6 self-assigned this Mar 12, 2024
@elasticmachine
Copy link

elasticmachine commented Mar 12, 2024 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review March 12, 2024 07:45
@efd6 efd6 requested a review from a team as a code owner March 12, 2024 07:45
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@ShourieG ShourieG self-requested a review March 12, 2024 08:08
@efd6 efd6 requested a review from ShourieG March 12, 2024 20:13
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% 100.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

ShourieG
ShourieG approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@ShourieG ShourieG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efd6 efd6 merged commit cddf031 into elastic:main Mar 13, 2024
5 checks passed
@elasticmachine
Copy link

Package carbon_black_cloud - 1.21.1 containing this change is available at https://epr.elastic.co/search?package=carbon_black_cloud

gizas pushed a commit that referenced this pull request Mar 13, 2024
@efd6 @gizas
carbon_black_cloud: fix handling of network direction (#9340)
bbda3f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShourieG ShourieG ShourieG approved these changes

Assignees

@efd6 efd6

Labels
bugfix Integration:CarbonBlackCloud Carbon Black Cloud Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Carbon Black Cloud] Network Direction/Source IP/Client IP
3 participants
@efd6 @elasticmachine @ShourieG