Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sentinel_one_cloud_funnel: improve process handling #9361

Merged
merged 1 commit into from
Mar 17, 2024
Merged

sentinel_one_cloud_funnel: improve process handling #9361

merged 1 commit into from
Mar 17, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 13, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration:sentinel_one_cloud_funnel SentinelOne Cloud Funnel Team:Security-Service Integrations Security Service Integrations Team labels Mar 13, 2024
@efd6 efd6 self-assigned this Mar 13, 2024
@efd6 efd6 force-pushed the 9120-sentinel_one_cloud_funnel branch from a5d56f8 to 47f5906 Compare March 13, 2024 23:27
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate failed Quality Gate failed

Failed conditions

66.7% 66.7% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

cc @efd6

@efd6 efd6 marked this pull request as ready for review March 13, 2024 23:45
@efd6 efd6 requested a review from a team as a code owner March 13, 2024 23:45
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

kcreddy
kcreddy approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@kcreddy
Copy link
Contributor

kcreddy commented Mar 15, 2024

Looks like SonarQube is complaining on code coverage for new processors added .

@efd6
Copy link
Contributor Author

efd6 commented Mar 17, 2024

Yep 1/2 is less than 80%. The documentation doesn't support fabricating new tests, so I am leaving it.

@efd6 efd6 merged commit f7bcc26 into elastic:main Mar 17, 2024
4 of 5 checks passed
@elasticmachine
Copy link

Package sentinel_one_cloud_funnel - 0.13.0 containing this change is available at https://epr.elastic.co/search?package=sentinel_one_cloud_funnel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration:sentinel_one_cloud_funnel SentinelOne Cloud Funnel Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@efd6 @elasticmachine @kcreddy