Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[windows] Map host.os.type explicitly for all data streams. #9367

Closed
wants to merge 1 commit into from

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Mar 14, 2024

Proposed commit message

Adds explicit mapping for host.os.type.

Newer versions of the stack will add the ECS templates automatically, but since this integrations is supported since 8.8 this will fix any potential error in mappings for this field.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Copy link

cla-checker-service bot commented Mar 14, 2024

❌ Author of the following commits did not sign a Contributor Agreement:
970abd5

Please, read and sign the above mentioned agreement if you want to contribute to this project

@marc-gr marc-gr marked this pull request as ready for review March 14, 2024 12:02
@marc-gr marc-gr requested review from a team as code owners March 14, 2024 12:02
@elasticmachine
Copy link

elasticmachine commented Mar 14, 2024

🚀 Benchmarks report

Package windows 👍(4) 💚(0) 💔(4)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
applocker_msi_and_script 9803.92 7575.76 -2228.16 (-22.73%) 💔
applocker_packaged_app_deployment 14084.51 9259.26 -4825.25 (-34.26%) 💔
applocker_packaged_app_execution 22222.22 12345.68 -9876.54 (-44.44%) 💔
forwarded 1176.47 887.31 -289.16 (-24.58%) 💔

To see the full report comment with /test benchmark fullreport

@marc-gr marc-gr force-pushed the fix/windows-host.os.type branch 2 times, most recently from 70b08c1 to f6714b1 Compare March 14, 2024 12:31
@marc-gr
Copy link
Contributor Author

marc-gr commented Mar 14, 2024

/cla

@marc-gr marc-gr force-pushed the fix/windows-host.os.type branch 3 times, most recently from 30b8a39 to 527f78a Compare March 14, 2024 13:41
@marc-gr
Copy link
Contributor Author

marc-gr commented Mar 14, 2024

/cla

@elasticmachine
Copy link

💚 Build Succeeded

History

Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link

Package windows - 1.44.4 containing this change is available at https://epr.elastic.co/search?package=windows

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants