Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qualys_vmdr: increase request timeout and document #9371

Merged
merged 1 commit into from Mar 17, 2024
Merged

qualys_vmdr: increase request timeout and document #9371

merged 1 commit into from Mar 17, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Mar 14, 2024 •
edited

Requests to the API may take significant time to complete, so increase the default and document that short timeouts may cause requests to fail to help users avoid this issue.

Proposed commit message

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added enhancement New feature or request Integration: Qualys VMDR Team:Security-Service Integrations Security Service Integrations Team labels Mar 14, 2024
@efd6 efd6 self-assigned this Mar 14, 2024
@efd6
qualys_vmdr: increase request timeout and document
0591b7e 
Requests to the API may take significant time to complete, so increase
the default and document that short timeouts may cause requests to fail
to help users avoid this issue.
@elasticmachine
Copy link

🚀 Benchmarks report

Package qualys_vmdr 👍(1) 💚(0) 💔(1)

Expand to view
Data stream Previous EPS New EPS Diff (%) Result
knowledge_base 1730.1 1342.28 -387.82 (-22.42%) 💔

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@efd6 efd6 marked this pull request as ready for review March 14, 2024 23:02
@efd6 efd6 requested a review from a team as a code owner March 14, 2024 23:02
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

kcreddy
kcreddy approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@efd6 efd6 merged commit b5d1e40 into elastic:main Mar 17, 2024
5 checks passed
@elasticmachine
Copy link

Package qualys_vmdr - 2.1.0 containing this change is available at https://epr.elastic.co/search?package=qualys_vmdr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcreddy kcreddy kcreddy approved these changes

Assignees

@efd6 efd6

Labels
enhancement New feature or request Integration: Qualys VMDR Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Default configuration causing an ingestion error
3 participants
@efd6 @elasticmachine @kcreddy