Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TI_Cybersixgill] Add IOC expiration support #9374

Merged
merged 3 commits into from Mar 18, 2024
Merged

[TI_Cybersixgill] Add IOC expiration support #9374

merged 3 commits into from Mar 18, 2024

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Mar 15, 2024 •
edited

Proposed commit message

  • Add IOC expiration support

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

How to test this PR locally

elastic-package build && elastic-package stack up -d -v && eval "$(elastic-package stack shellinit)" && elastic-package test pipeline --generate -v

Related issues

Screenshots

Screenshot 2024-03-16 at 1 36 03 AM Screenshot 2024-03-16 at 1 35 34 AM

@kcreddy kcreddy added enhancement New feature or request Integration:Cybersixgill Team:Security-Service Integrations Security Service Integrations Team labels Mar 15, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@kcreddy kcreddy marked this pull request as ready for review March 15, 2024 20:56
@kcreddy kcreddy requested a review from a team as a code owner March 15, 2024 20:56
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

efd6
efd6 approved these changes Mar 17, 2024
View reviewed changes
packages/ti_cybersixgill/data_stream/threat/elasticsearch/ingest_pipeline/default.yml Outdated
Comment on lines 119 to 120
if: ctx.threat?.indicator?.file?.hash?.md5 != null
ignore_empty_value: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need both of these?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Removed if

@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% 100.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@kcreddy kcreddy merged commit 44acbab into elastic:main Mar 18, 2024
5 checks passed
@elasticmachine
Copy link

Package ti_cybersixgill - 1.27.0 containing this change is available at https://epr.elastic.co/search?package=ti_cybersixgill

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request Integration:Cybersixgill Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[TI_Cybersixgill] Add support for IOC expiration
3 participants
@kcreddy @elasticmachine @efd6