Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eset_protect] Enhancing ECS fields #9382

Merged
merged 8 commits into from
Mar 20, 2024
Merged

Conversation

LaZyDK
Copy link
Contributor

@LaZyDK LaZyDK commented Mar 18, 2024

Add mappings for host.name, host.domain, file.drive_letter, file.name, file.path and file.directory.

New tests obtained from a production environment after sanitisation.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@LaZyDK LaZyDK requested a review from a team as a code owner March 18, 2024 18:37
@LaZyDK
Copy link
Contributor Author

LaZyDK commented Mar 18, 2024

Ready for tests

@P1llus
Copy link
Member

P1llus commented Mar 18, 2024

/test

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@P1llus P1llus added enhancement New feature or request Team:Security-Service Integrations Security Service Integrations Team Integration:ESET Threat Intelligence labels Mar 18, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

LaZyDK and others added 3 commits March 18, 2024 22:26
…ipeline/default.yml

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
…ipeline/default.yml

Co-authored-by: Dan Kortschak <90160302+efd6@users.noreply.github.com>
@LaZyDK
Copy link
Contributor Author

LaZyDK commented Mar 18, 2024

Fixed. Please confirm and retest.

@efd6
Copy link
Contributor

efd6 commented Mar 18, 2024

/test

…ipeline/default.yml

Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
@efd6
Copy link
Contributor

efd6 commented Mar 20, 2024

/test

@efd6 efd6 enabled auto-merge (squash) March 20, 2024 07:19
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@elasticmachine
Copy link

💚 Build Succeeded

History

@efd6 efd6 merged commit 30daef6 into elastic:main Mar 20, 2024
3 checks passed
Copy link

@LaZyDK LaZyDK deleted the eset-ecs-fixup branch March 20, 2024 07:25
@elasticmachine
Copy link

Package eset_protect - 0.3.0 containing this change is available at https://epr.elastic.co/search?package=eset_protect

@elasticmachine
Copy link

Package eset_protect - 0.4.0 containing this change is available at https://epr.elastic.co/search?package=eset_protect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants