Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fortinet_fortigate] Add more sanitization for unwanted characters. #9384

Merged
merged 2 commits into from
Mar 21, 2024
Merged

[fortinet_fortigate] Add more sanitization for unwanted characters. #9384

merged 2 commits into from
Mar 21, 2024

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Mar 19, 2024

Proposed commit message

Adds sanitization for malformed keys to avoid mapping explosion under malformed inputs.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

@marc-gr marc-gr force-pushed the feat/fortigate-sanitization branch from 5573f32 to 8ce4c6e Compare March 19, 2024 09:21
@marc-gr marc-gr marked this pull request as ready for review March 19, 2024 09:21
@marc-gr marc-gr requested a review from a team as a code owner March 19, 2024 09:21
@elasticmachine
Copy link

elasticmachine commented Mar 19, 2024 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@marc-gr marc-gr added the Team:Security-Deployment and Devices Deployment and Devices Security team label Mar 19, 2024
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% 100.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@marc-gr marc-gr requested a review from mjwolf March 20, 2024 12:03
@marc-gr marc-gr enabled auto-merge (squash) March 20, 2024 12:05
mjwolf
mjwolf approved these changes Mar 21, 2024
View reviewed changes
Copy link
Contributor

@mjwolf mjwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@marc-gr marc-gr merged commit 9c2cbdc into elastic:main Mar 21, 2024
5 checks passed
@elasticmachine
Copy link

Package fortinet_fortigate - 1.25.0 containing this change is available at https://epr.elastic.co/search?package=fortinet_fortigate

@marc-gr marc-gr deleted the feat/fortigate-sanitization branch March 22, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjwolf mjwolf mjwolf approved these changes

@taylor-swanson taylor-swanson Awaiting requested review from taylor-swanson

Assignees
No one assigned
Labels
enhancement New feature or request Integration:Fortinet_FortiGate Team:Security-Deployment and Devices Deployment and Devices Security team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marc-gr @elasticmachine @mjwolf