cisco_meraki: fix webhook configuration and behavior #9415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efd6
added
Integration:Cisco Meraki
bugfix
Team:Security-Service Integrations
efd6
force-pushed
the
9388-cisco_meraki
branch
2 times, most recently
from
ac540bb
to
27df016
Compare
Cisco Meraki's approach to 'authentication' is not actually based on authentication. Instead a shared secret is passed as part of the event that is sent in the web hook publication[1]. So, in order to prevent ingestion of invalid or unauthorised events, check for shared secret matching in the ingest pipeline and drop event that do not match. Note that Cisco Meraki's approach does not provide any mechanism to prevent unauthorized connections. [1]https://developer.cisco.com/meraki/webhooks/introduction/#shared-secret
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
History
cc @efd6 |
|
100.0% Coverage on New Code
0.0% Duplication on New Code
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
|
Package cisco_meraki - 1.21.2 containing this change is available at https://epr.elastic.co/search?package=cisco_meraki |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Cisco Meraki's approach to 'authentication' is not actually based on authentication. Instead a shared secret is passed as part of the event that is sent in the web hook publication[1]. So, in order to prevent ingestion of invalid or unauthorised events, check for shared secret matching in the ingest pipeline and drop event that do not match.
Note that Cisco Meraki's approach does not provide any mechanism to prevent unauthorized connections.
[1]https://developer.cisco.com/meraki/webhooks/introduction/#shared-secret
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots