-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a period
parameter to the counter cache in remote write
#9424
Conversation
…g Prometheus rated counter metric to counter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
period
parameterto the counter cache in remote write
period
parameterto the counter cache in remote writeperiod
parameter to the counter cache in remote write
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Co-authored-by: subham sarkar <subham.sarkar@elastic.co>
Co-authored-by: subham sarkar <subham.sarkar@elastic.co>
@shmsr let me know if is ok now and we can merge this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
…s into remote_write_ratefix
💚 Build Succeeded
History
|
|
Package prometheus - 1.15.1 containing this change is available at https://epr.elastic.co/search?package=prometheus |
Proposed commit message
Checklist
changelog.yml
file.How to test this PR locally
cd packages/prometheus
elastic-package build
commandelastic-package stack up -d -v --version=8.14.0-SNAPSHOT
Related issues
Screenshots
For my local kubernetes cluster (40m evidence for correct rate calculation with elastic-agent-standalone manifest)