Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crowdstrike] Fix cache option name in FDR data stream. #9436

Merged
merged 1 commit into from Mar 25, 2024
Merged

[crowdstrike] Fix cache option name in FDR data stream. #9436

merged 1 commit into from Mar 25, 2024

Conversation

marc-gr
Copy link
Contributor

@marc-gr marc-gr commented Mar 25, 2024 •
edited

Proposed commit message

Fix cache option naming for FDR data stream: write_period to write_interval

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Relates elastic/beats#38561

@marc-gr marc-gr force-pushed the fix/crowdstrike_fdr_cache-opts branch from 6be9e31 to 74c8260 Compare March 25, 2024 10:41
@marc-gr marc-gr marked this pull request as ready for review March 25, 2024 10:41
@marc-gr marc-gr requested a review from a team as a code owner March 25, 2024 10:41
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@elasticmachine
Copy link

💚 Build Succeeded

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@marc-gr marc-gr requested a review from efd6 March 25, 2024 14:30
@marc-gr marc-gr merged commit aec76cc into elastic:main Mar 25, 2024
5 checks passed
@marc-gr marc-gr deleted the fix/crowdstrike_fdr_cache-opts branch March 25, 2024 14:40
@elasticmachine
Copy link

Package crowdstrike - 1.32.1 containing this change is available at https://epr.elastic.co/search?package=crowdstrike

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

@efd6 efd6 Awaiting requested review from efd6

Assignees
No one assigned
Labels
bugfix Integration:Crowdstrike Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@marc-gr @elasticmachine @andrewkroh