-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LastPass] Fix page index for event reports #9457
Conversation
|
💚 Build Succeeded
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a test for this or has it been tested manually?
Don't have the environment to test this. The options would be to test directly in customer environment or add system tests. Let me try and add system test |
@efd6, I ran existing system tests: https://github.com/elastic/integrations/blob/main/packages/lastpass/_dev/deploy/docker/files/config.yml#L9-L15 With current version i.e., page index as 1:
With this PR change i.e., page index updated to
|
Package lastpass - 1.15.1 containing this change is available at https://epr.elastic.co/search?package=lastpass |
Proposed commit message
The response page index starts with
0
as per the agent logs:"message":"last received page: &httpjson.response{page:0, .....{\"Event1\":map[string]interface {}{..... \"Time\":\"2024-02-14 21:20:48\", ......,
. The response at page0
containsEvent1
. But the input's cursor checks page index1
forEvent1
leading to failed template evaluation.Fixing it by updating the page index to
0
.Checklist
changelog.yml
file.Author's Checklist