Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RecordedFuture] Add dashboards and list field #9471

Merged
merged 5 commits into from Apr 3, 2024
Merged

[RecordedFuture] Add dashboards and list field #9471

merged 5 commits into from Apr 3, 2024

Conversation

kcreddy
Copy link
Contributor

@kcreddy kcreddy commented Mar 29, 2024 •
edited

Proposed commit message

  • Add dashboards and list field

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Screenshots

rf-urls rf-files rf-overview

@kcreddy kcreddy marked this pull request as ready for review March 29, 2024 12:06
@kcreddy kcreddy requested a review from a team as a code owner March 29, 2024 12:06
@kcreddy kcreddy added enhancement New feature or request Integration:Recorded Future Team:Security-Service Integrations Security Service Integrations Team labels Mar 29, 2024
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@kcreddy kcreddy self-assigned this Mar 29, 2024
efd6
efd6 reviewed Apr 2, 2024
View reviewed changes
packages/ti_recordedfuture/data_stream/threat/elasticsearch/ingest_pipeline/default.yml Outdated
@@ -237,6 +237,10 @@ processors:
- rename:
field: json
target_field: recordedfuture
- set:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a test case that exercises this? Also, is it worth using a rename instead of a set?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The field list is added to both the system test configs already that has httpjson as input. I think the CSV config (file input) is running last which is being taken into sample_event.json hence the field is missing in that file.

I changed the processor to rename.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @kcreddy

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
20.0% 20.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@kcreddy kcreddy merged commit 46704c0 into elastic:main Apr 3, 2024
5 checks passed
@elasticmachine
Copy link

Package ti_recordedfuture - 1.23.0 containing this change is available at https://epr.elastic.co/search?package=ti_recordedfuture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

@kcreddy kcreddy

Labels
enhancement New feature or request Integration:Recorded Future Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kcreddy @elasticmachine @efd6