Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prisma_cloud: update manifest version format to v3.0.3 #9517

Merged
merged 1 commit into from Apr 9, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Apr 3, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

Copy link

@efd6 efd6 marked this pull request as ready for review April 3, 2024 23:55
@efd6 efd6 requested a review from a team as a code owner April 3, 2024 23:55
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just clarification. LGTM 👍🏼

def set = new HashSet();
for (def a: aa) {
for (def e: a) {
set.add(e);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have deeply nested array? If its deeply nested, do you think at this point we check if e is not string, then recursively call flatten?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that is a thing in this data set.

@efd6 efd6 merged commit c714f54 into elastic:main Apr 9, 2024
5 checks passed
@elasticmachine
Copy link

Package prisma_cloud - 1.2.0 containing this change is available at https://epr.elastic.co/search?package=prisma_cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants