Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cisco_aironet]: handle CLIENT_ORCH_LOG messages #9545

Merged
merged 1 commit into from
Apr 8, 2024
Merged

[cisco_aironet]: handle CLIENT_ORCH_LOG messages #9545

merged 1 commit into from
Apr 8, 2024

Conversation

pkoutsovasilis
Copy link
Contributor

Proposed commit message

This PR fixes parsing of CLIENT_ORCH_LOG in cisco aironet integration

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

N/A

How to test this PR locally

Related issues

Screenshots

N/A

@pkoutsovasilis pkoutsovasilis added bug Something isn't working Integration:CiscoAironet Team:Security-Deployment and Devices Deployment and Devices Security team labels Apr 8, 2024
@pkoutsovasilis pkoutsovasilis requested a review from a team as a code owner April 8, 2024 13:41
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@pkoutsovasilis pkoutsovasilis changed the title fix(cisco_aironet): handle CLIENT_ORCH_LOG messages [cisco_aironet]: handle CLIENT_ORCH_LOG messages Apr 8, 2024
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

mjwolf
mjwolf reviewed Apr 8, 2024
View reviewed changes
Copy link
Contributor

@mjwolf mjwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, other than the changelog link

packages/cisco_aironet/changelog.yml Outdated Show resolved Hide resolved
...ges/cisco_aironet/data_stream/log/_dev/test/pipeline/test-aironet-messages.log-expected.json Show resolved Hide resolved
@pkoutsovasilis pkoutsovasilis force-pushed the pkoutsovasilis/cisco_aironet_client_orch_log branch from 2d4ea42 to 9b4d681 Compare April 8, 2024 17:28
@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% 100.0% Coverage on New Code
0.0% 0.0% Duplication on New Code

See analysis details on SonarQube

@pkoutsovasilis pkoutsovasilis merged commit f2ea742 into main Apr 8, 2024
5 checks passed
@pkoutsovasilis pkoutsovasilis deleted the pkoutsovasilis/cisco_aironet_client_orch_log branch April 8, 2024 18:23
@elasticmachine
Copy link

Package cisco_aironet - 1.13.1 containing this change is available at https://epr.elastic.co/search?package=cisco_aironet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjwolf mjwolf mjwolf approved these changes

Assignees
No one assigned
Labels
bug Something isn't working Integration:CiscoAironet Team:Security-Deployment and Devices Deployment and Devices Security team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Grok bug cisco_aironet.log version 1.12.1
3 participants
@pkoutsovasilis @elasticmachine @mjwolf