Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate content on the Azure Monitor Metrics doc page #9597

Merged
merged 9 commits into from
Apr 17, 2024
Merged

Consolidate content on the Azure Monitor Metrics doc page #9597

merged 9 commits into from
Apr 17, 2024

Conversation

alaudazzi
Copy link
Contributor

@alaudazzi alaudazzi commented Apr 15, 2024 •
edited
Loading

Proposed commit message

On the Monitor metrics, this PR:

  • Removes duplicate and confusing content related to Kibana configurations, authentication, and costs.
  • Replaces this content with references to generic instructions clearly documented on the Azure Resource Metrics page.
  • Adds the Requirements and Setup sections to comply with the documentation guidelines.

Related issues

Screenshots

image image

@alaudazzi alaudazzi added documentation Improvements or additions to documentation enhancement New feature or request >enhancement labels Apr 15, 2024
@elasticmachine
Copy link

elasticmachine commented Apr 15, 2024 •
edited
Loading

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@alaudazzi alaudazzi marked this pull request as ready for review April 16, 2024 12:34
@alaudazzi alaudazzi requested a review from a team as a code owner April 16, 2024 12:34
zmoog
zmoog approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I added minor changes to capitalization (it's a long fight; we need to start somewhere).

packages/azure_metrics/_dev/build/docs/monitor.md Outdated Show resolved Hide resolved
@muthu-mps
Copy link
Contributor

Overall change looks good.

Few comments,

  • Can we make the reference link to be inserted. Instead of showing the entire URL.
  • nit: Please add dot at the end of the line to make it consistent.
Screenshot 2024-04-17 at 7 24 24 PM

muthu-mps
muthu-mps approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@muthu-mps muthu-mps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@alaudazzi alaudazzi merged commit 2593237 into elastic:main Apr 17, 2024
5 checks passed
@elasticmachine
Copy link

Package azure_metrics - 1.6.1 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation enhancement New feature or request >enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alaudazzi @elasticmachine @muthu-mps @zmoog