Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate content on the Azure Container Registry Metrics doc page #9615

Merged
merged 5 commits into from
Apr 22, 2024
Merged

Consolidate content on the Azure Container Registry Metrics doc page #9615

merged 5 commits into from
Apr 22, 2024

Conversation

alaudazzi
Copy link
Contributor

Proposed commit message

On the Azure Container Registry Metrics, this PR:

  • Removes duplicate and confusing content related to Kibana configurations, authentication, and costs.
  • Replaces this content with references to generic instructions clearly documented on the Azure Resource Metrics page.
  • Adds the Requirements and Setup sections to comply with the documentation guidelines.

Related issues

@alaudazzi alaudazzi added documentation Improvements or additions to documentation >enhancement labels Apr 16, 2024
@alaudazzi alaudazzi requested a review from a team as a code owner April 16, 2024 13:55
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

zmoog
zmoog approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link

💚 Build Succeeded

History

@alaudazzi alaudazzi merged commit 3b7ea6c into elastic:main Apr 22, 2024
5 checks passed
@elasticmachine
Copy link

Package azure_metrics - 1.6.2 containing this change is available at https://epr.elastic.co/search?package=azure_metrics

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation >enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alaudazzi @elasticmachine @zmoog @muthu-mps