Fix typo in elastic agent dashboard #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
kaiyan-sheng
approved these changes
Apr 29, 2021
ycombinator
reviewed
Apr 29, 2021
| } |
There was a problem hiding this comment.
I suspect this newline change is why the CI build is failing. CI is pretty strict about formatting.
[2021-04-29T22:36:03.315Z] Error: checking package failed: formatting the integration failed (path: /var/lib/jenkins/workspace/gest-manager_integrations_PR-962/src/github.com/elastic/integrations/packages/elastic_agent, failFast: true): walking through the integration files failed: formatting file failed (path: /var/lib/jenkins/workspace/gest-manager_integrations_PR-962/src/github.com/elastic/integrations/packages/elastic_agent/kibana/dashboard/elastic_agent-f47f18cc-9c7d-4278-b2ea-a6dee816d395.json): file is not formatted (path: /var/lib/jenkins/workspace/gest-manager_integrations_PR-962/src/github.com/elastic/integrations/packages/elastic_agent/kibana/dashboard/elastic_agent-f47f18cc-9c7d-4278-b2ea-a6dee816d395.json)
From anywhere under the packages/elastic_agent folder, run elastic-package format. That should fix up any formatting.
There was a problem hiding this comment.
I made this change through the GitHub UI. I don't have this project checked out yet.
There was a problem hiding this comment.
Ah, I see. Let me push up a commit that fixes the formatting.
ycombinator
force-pushed
the
smith-patch-1
branch
from
2c1ded3
to
7869e44
Compare
mtojek
suggested changes
Apr 30, 2021
|
/test |
mtojek
approved these changes
May 4, 2021
james-elastic
pushed a commit
to james-elastic/integrations
that referenced
this pull request
Jun 30, 2021
* Fix typo in elastic agent dashboard * Running elastic-package format * Changelog and version bump * Debug: git diff to Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> Co-authored-by: mtojek <marcin.tojek@elastic.co>
eyalkraft
pushed a commit
to build-security/integrations
that referenced
this pull request
Mar 30, 2022
* Fix typo in elastic agent dashboard * Running elastic-package format * Changelog and version bump * Debug: git diff to Co-authored-by: Shaunak Kashyap <ycombinator@gmail.com> Co-authored-by: mtojek <marcin.tojek@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix typo in elastic agent dashboard
Checklist
changelog.ymlfile.