Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sentinel_one_cloud_funnel: fix original data preservation for gcs #9627

Merged
merged 1 commit into from Apr 17, 2024

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Apr 17, 2024

Proposed commit message

See title.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@efd6 efd6 added bug Something isn't working Integration: SentinelOne Cloud Funnel Team:Security-Service Integrations Security Service Integrations Team labels Apr 17, 2024
@efd6 efd6 self-assigned this Apr 17, 2024
@efd6 efd6 force-pushed the sentinel_one_gcs_preserve_original branch from 8fdfad4 to ead9898 Compare April 17, 2024 00:45
@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@efd6 efd6 marked this pull request as ready for review April 17, 2024 01:27
@efd6 efd6 requested a review from a team as a code owner April 17, 2024 01:27
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@kcreddy kcreddy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor suggestion. LGTM 👍🏼

- version: "0.14.1"
changes:
- description: Add missing event preservation template expansions for GCS input.
type: enhancement
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type: enhancement
type: bugfix

I see based on patch version increment and also based on labels that its supposed to be bugfix?

@efd6 efd6 force-pushed the sentinel_one_gcs_preserve_original branch from ead9898 to 4616d38 Compare April 17, 2024 10:02
@efd6 efd6 enabled auto-merge (squash) April 17, 2024 10:02
@elasticmachine
Copy link

💚 Build Succeeded

History

cc @efd6

@efd6 efd6 merged commit 5631bff into elastic:main Apr 17, 2024
4 checks passed
Copy link

Quality Gate passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No Coverage information No data about Coverage
No Duplication information No data about Duplication

See analysis details on SonarQube

@elasticmachine
Copy link

Package sentinel_one_cloud_funnel - 0.14.1 containing this change is available at https://epr.elastic.co/search?package=sentinel_one_cloud_funnel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Integration: SentinelOne Cloud Funnel Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants