Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[juniper_netscreen]: include log.file.device_id and log.file.inode in base-fields #9658

Merged
merged 2 commits into from
Apr 24, 2024
Merged

[juniper_netscreen]: include log.file.device_id and log.file.inode in base-fields #9658

merged 2 commits into from
Apr 24, 2024

Conversation

pkoutsovasilis
Copy link
Contributor

Proposed commit message

This PR fixes the following error for juniper_netscreen integration

one or more errors found in documents stored in logs-juniper_netscreen.log-ep data stream: [0] field "log.file.device_id" is undefined
[1] field "log.file.inode" is undefined

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

N/A

How to test this PR locally

elastic-package test system

Related issues

Screenshots

N/A

@pkoutsovasilis pkoutsovasilis force-pushed the pkoutsovasilis/fix_juniper_netscreen branch from c9c8a0b to 632491d Compare April 22, 2024 08:52
@pkoutsovasilis pkoutsovasilis self-assigned this Apr 22, 2024
@pkoutsovasilis pkoutsovasilis added bug Something isn't working Team:Security-Deployment and Devices Deployment and Devices Security team integration:Juniper Netscreen labels Apr 22, 2024
@pkoutsovasilis pkoutsovasilis marked this pull request as ready for review April 22, 2024 08:52
@pkoutsovasilis pkoutsovasilis requested a review from a team as a code owner April 22, 2024 08:52
@elasticmachine
Copy link

Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices)

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@taylor-swanson
Copy link
Contributor

/test

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @pkoutsovasilis

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@pkoutsovasilis pkoutsovasilis merged commit c563bb3 into main Apr 24, 2024
5 checks passed
@pkoutsovasilis pkoutsovasilis deleted the pkoutsovasilis/fix_juniper_netscreen branch April 24, 2024 16:40
gizas pushed a commit that referenced this pull request Apr 26, 2024
@pkoutsovasilis @gizas
[juniper_netscreen]: include log.file.device_id and log.file.inode in…
4836b7b 
… base-fields (#9658)

* fix(juniper_netscreen): include log.file.device_id and log.file.inode in base-fields.yml

* fix(juniper_netscreen): update README.md
milan-elastic pushed a commit to milan-elastic/integrations that referenced this pull request May 1, 2024
Squashed commit of the following:
a17de73 
commit fccdb1f
Author: milan-elastic <milan.parmar@elastic.co>
Date:   Wed May 1 14:58:41 2024 +0530

    add global filter on dashboard level for hadoop

commit 686e49b
Merge: 024d864 01201a7
Author: “milan-elastic” <“milan.parmar@elastic.co”>
Date:   Wed May 1 11:38:59 2024 +0530

    Merge branch 'main' of github.com:milan-elastic/integrations into mongodb-atlas-database-logs

commit 01201a7
Author: Eric Forte <119343520+eric-forte-elastic@users.noreply.github.com>
Date:   Tue Apr 30 10:46:55 2024 -0400

    [Security Rules] Update security rules package to v8.13.5 (elastic#9762)

    * [Security Rules] Update security rules package to v8.13.5

    * Add changelog entry for 8.13.5

    ---------

    Co-authored-by: protectionsmachine <72879786+protectionsmachine@users.noreply.github.com>

commit c9d1f1b
Author: Eric Forte <119343520+eric-forte-elastic@users.noreply.github.com>
Date:   Tue Apr 30 09:30:30 2024 -0400

    [Security Rules] Update security rules package to v8.13.5-beta.1 (elastic#9758)

    * [Security Rules] Update security rules package to v8.13.5-beta.1

    * Add changelog entry for 8.13.5-beta.1

    ---------

    Co-authored-by: protectionsmachine <72879786+protectionsmachine@users.noreply.github.com>

commit a79f813
Author: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
Date:   Tue Apr 30 11:32:37 2024 +0200

    [kubernetes] Remove deprecated fields, add missing status.last_terminated_reason metric (elastic#9736)

    * remove deprecated fields

    Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

    * Update changelog.yml

    * add missing metric: last_terminated_reason; update description of the status.reason field

    Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

    ---------

    Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

commit b1627a3
Author: ShourieG <105607378+ShourieG@users.noreply.github.com>
Date:   Tue Apr 30 13:03:29 2024 +0530

    [integrations][http_endpoint] - Converted HTTP Endpoint Integration to input type (elastic#9732)

    * converted http_endpoint to input package type

    * updated changelog

    * updated original event in sample event

commit 3a9b508
Author: Lalit Satapathy <69236064+lalit-satapathy@users.noreply.github.com>
Date:   Tue Apr 30 11:49:09 2024 +0530

    Remove separate codeowners for system package kibana paths. (elastic#9731)

commit c90e817
Author: Krishna Chaitanya Reddy Burri <krishnachaitanyareddy.burri@elastic.co>
Date:   Tue Apr 30 11:32:17 2024 +0530

    [Crowdstrike,Azure] Fix flaky tests with ECS fields (elastic#9738)

    * Fix flaky pipeline tests.

       * `azure.graphactivitylogs`: Add missing ECS field definitions.

       * `crowdstrike.falcon`: Update `geoip` processor to `destination` instead of `source`.

commit ace8fb4
Author: Aliabbas Attarwala <124054599+aliabbas-elastic@users.noreply.github.com>
Date:   Mon Apr 29 16:37:23 2024 +0530

    [O11y][AWS] Rally benchmark `aws.cloudtrail` (elastic#9448)

commit d4e4aa4
Author: niraj-elastic <124254029+niraj-elastic@users.noreply.github.com>
Date:   Mon Apr 29 14:45:46 2024 +0530

    [Apache] Update grok pattern for accepting user-identity (elastic#9632)

    * update grok pattern

    * update changelog

    * address review comments

    * address review comments

    Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>

    * address review comments

    * address review comment

    ---------

    Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>

commit dce5699
Author: Mario Rodriguez Molins <mario.rodriguez@elastic.co>
Date:   Mon Apr 29 10:33:19 2024 +0200

    Enable publishing packages from integrations-publish pipeline (elastic#9712)

    Enable publishing packages from integrations-publish pipeline,
    and remove corresponding step from the main pipeline.

commit c7bc530
Author: Chema Martínez <chema.martinez@elastic.co>
Date:   Sat Apr 27 08:57:55 2024 +0200

    [zscaler_zia] Fix mapping of source.ip and source.nat.ip (elastic#9727)

    * Fix mapping of source.ip and source.nat.ip

    * Update changelog

    * updated web datastream pipeline tests

    ---------

    Co-authored-by: Shourie Ganguly <shourie.ganguly@elastic.co>

commit 4750ea8
Author: Mario Rodriguez Molins <mario.rodriguez@elastic.co>
Date:   Fri Apr 26 13:09:53 2024 +0200

    [nginx] Update nginx config to listen in ipv6 too (elastic#9720)

commit 25b0988
Author: Mario Rodriguez Molins <mario.rodriguez@elastic.co>
Date:   Fri Apr 26 10:45:03 2024 +0200

    [Buildkite] Update filter to use api source (elastic#9717)

commit 45327cf
Author: Mario Rodriguez Molins <mario.rodriguez@elastic.co>
Date:   Fri Apr 26 10:13:22 2024 +0200

    [Buildkite] Update filter condition to allow just from webhook source (elastic#9714)

commit 024d864
Author: milan-elastic <milan.parmar@elastic.co>
Date:   Fri Apr 26 13:00:47 2024 +0530

    add dashboard level filter for apache tomcat

commit 1cb5fad
Author: Dan Kortschak <dan.kortschak@elastic.co>
Date:   Fri Apr 26 16:23:35 2024 +0930

    entityanalytics_ad: new package for Active Directory user collection (elastic#9485)

commit 37c598f
Author: CarsonHrusovsky <95260807+CarsonHrusovsky@users.noreply.github.com>
Date:   Thu Apr 25 18:13:26 2024 -0500

    [BBOT] New integration for Black Lantern Security scanner (elastic#9651)

commit d13e474
Author: Mario Rodriguez Molins <mario.rodriguez@elastic.co>
Date:   Thu Apr 25 11:55:39 2024 +0200

    [Buildkite] Skip install package command in serverless builds for some packages (elastic#9686)

commit 0c2198b
Author: Mario Rodriguez Molins <mario.rodriguez@elastic.co>
Date:   Thu Apr 25 11:41:42 2024 +0200

    [Buildkite] Add retry suffix for logs (elastic#9703)

commit d932e79
Author: Simon Kötting <145989254+SimonKoetting@users.noreply.github.com>
Date:   Thu Apr 25 07:35:45 2024 +0200

    [Exchange Server] GA of Integration, Add Dashbord Panel Titles & System Tests (elastic#9560)

    * Add Dashboard Titles

    * Add Dashboard Titles

    * Change Version to GA

    * adjust PR in Changelog

    * Add System Tests to all datstreams

    * fix imap system test config

    * remove Folder structure out of system tests sample logs

    * Fix mapping

    * Add convert for inode field

    * specify numeric_keyword_fields in system tests

commit dba2901
Author: Dan Kortschak <dan.kortschak@elastic.co>
Date:   Thu Apr 25 10:21:30 2024 +0930

    rapid7_insightvm: canonicalize host.name to lower case and map subdomain to host.hostname (elastic#9665)

commit 4284262
Author: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
Date:   Wed Apr 24 20:34:13 2024 +0300

    fix(fim): add auto option for backend and make it the default one (elastic#9702)

commit c563bb3
Author: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
Date:   Wed Apr 24 19:40:04 2024 +0300

    [juniper_netscreen]: include log.file.device_id and log.file.inode in base-fields (elastic#9658)

    * fix(juniper_netscreen): include log.file.device_id and log.file.inode in base-fields.yml

    * fix(juniper_netscreen): update README.md

commit f187d0d
Author: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
Date:   Wed Apr 24 19:11:28 2024 +0300

    [juniper_junos]: include log.file.device_id and log.file.inode in base-fields (elastic#9657)

    * fix(juniper_junos): include log.file.device_id and log.file.inode in base-fields.yml

    * fix(juniper_junos): update README.md
milan-elastic added a commit to milan-elastic/integrations that referenced this pull request May 1, 2024
@milan-elastic
Squashed commit of the following:
8cf8f03 
commit e2a688fbb1c8712ba0cad243713146867ac2f986
Author: milan-elastic <milan.Parmar@elastic.co>
Date:   Wed May 1 15:43:52 2024 +0530

    Squashed commit of the following:

    commit a17de73
    Author: milan-elastic <“milan.parmar@elastic.co”>
    Date:   Wed May 1 15:29:41 2024 +0530

        Squashed commit of the following:

        commit fccdb1f
        Author: milan-elastic <milan.parmar@elastic.co>
        Date:   Wed May 1 14:58:41 2024 +0530

            add global filter on dashboard level for hadoop

        commit 686e49b
        Merge: 024d864 01201a7
        Author: “milan-elastic” <“milan.parmar@elastic.co”>
        Date:   Wed May 1 11:38:59 2024 +0530

            Merge branch 'main' of github.com:milan-elastic/integrations into mongodb-atlas-database-logs

        commit 01201a7
        Author: Eric Forte <119343520+eric-forte-elastic@users.noreply.github.com>
        Date:   Tue Apr 30 10:46:55 2024 -0400

            [Security Rules] Update security rules package to v8.13.5 (elastic#9762)

            * [Security Rules] Update security rules package to v8.13.5

            * Add changelog entry for 8.13.5

            ---------

            Co-authored-by: protectionsmachine <72879786+protectionsmachine@users.noreply.github.com>

        commit c9d1f1b
        Author: Eric Forte <119343520+eric-forte-elastic@users.noreply.github.com>
        Date:   Tue Apr 30 09:30:30 2024 -0400

            [Security Rules] Update security rules package to v8.13.5-beta.1 (elastic#9758)

            * [Security Rules] Update security rules package to v8.13.5-beta.1

            * Add changelog entry for 8.13.5-beta.1

            ---------

            Co-authored-by: protectionsmachine <72879786+protectionsmachine@users.noreply.github.com>

        commit a79f813
        Author: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>
        Date:   Tue Apr 30 11:32:37 2024 +0200

            [kubernetes] Remove deprecated fields, add missing status.last_terminated_reason metric (elastic#9736)

            * remove deprecated fields

            Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

            * Update changelog.yml

            * add missing metric: last_terminated_reason; update description of the status.reason field

            Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

            ---------

            Signed-off-by: Tetiana Kravchenko <tetiana.kravchenko@elastic.co>

        commit b1627a3
        Author: ShourieG <105607378+ShourieG@users.noreply.github.com>
        Date:   Tue Apr 30 13:03:29 2024 +0530

            [integrations][http_endpoint] - Converted HTTP Endpoint Integration to input type (elastic#9732)

            * converted http_endpoint to input package type

            * updated changelog

            * updated original event in sample event

        commit 3a9b508
        Author: Lalit Satapathy <69236064+lalit-satapathy@users.noreply.github.com>
        Date:   Tue Apr 30 11:49:09 2024 +0530

            Remove separate codeowners for system package kibana paths. (elastic#9731)

        commit c90e817
        Author: Krishna Chaitanya Reddy Burri <krishnachaitanyareddy.burri@elastic.co>
        Date:   Tue Apr 30 11:32:17 2024 +0530

            [Crowdstrike,Azure] Fix flaky tests with ECS fields (elastic#9738)

            * Fix flaky pipeline tests.

               * `azure.graphactivitylogs`: Add missing ECS field definitions.

               * `crowdstrike.falcon`: Update `geoip` processor to `destination` instead of `source`.

        commit ace8fb4
        Author: Aliabbas Attarwala <124054599+aliabbas-elastic@users.noreply.github.com>
        Date:   Mon Apr 29 16:37:23 2024 +0530

            [O11y][AWS] Rally benchmark `aws.cloudtrail` (elastic#9448)

        commit d4e4aa4
        Author: niraj-elastic <124254029+niraj-elastic@users.noreply.github.com>
        Date:   Mon Apr 29 14:45:46 2024 +0530

            [Apache] Update grok pattern for accepting user-identity (elastic#9632)

            * update grok pattern

            * update changelog

            * address review comments

            * address review comments

            Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>

            * address review comments

            * address review comment

            ---------

            Co-authored-by: muthu-mps <101238137+muthu-mps@users.noreply.github.com>

        commit dce5699
        Author: Mario Rodriguez Molins <mario.rodriguez@elastic.co>
        Date:   Mon Apr 29 10:33:19 2024 +0200

            Enable publishing packages from integrations-publish pipeline (elastic#9712)

            Enable publishing packages from integrations-publish pipeline,
            and remove corresponding step from the main pipeline.

        commit c7bc530
        Author: Chema Martínez <chema.martinez@elastic.co>
        Date:   Sat Apr 27 08:57:55 2024 +0200

            [zscaler_zia] Fix mapping of source.ip and source.nat.ip (elastic#9727)

            * Fix mapping of source.ip and source.nat.ip

            * Update changelog

            * updated web datastream pipeline tests

            ---------

            Co-authored-by: Shourie Ganguly <shourie.ganguly@elastic.co>

        commit 4750ea8
        Author: Mario Rodriguez Molins <mario.rodriguez@elastic.co>
        Date:   Fri Apr 26 13:09:53 2024 +0200

            [nginx] Update nginx config to listen in ipv6 too (elastic#9720)

        commit 25b0988
        Author: Mario Rodriguez Molins <mario.rodriguez@elastic.co>
        Date:   Fri Apr 26 10:45:03 2024 +0200

            [Buildkite] Update filter to use api source (elastic#9717)

        commit 45327cf
        Author: Mario Rodriguez Molins <mario.rodriguez@elastic.co>
        Date:   Fri Apr 26 10:13:22 2024 +0200

            [Buildkite] Update filter condition to allow just from webhook source (elastic#9714)

        commit 024d864
        Author: milan-elastic <milan.parmar@elastic.co>
        Date:   Fri Apr 26 13:00:47 2024 +0530

            add dashboard level filter for apache tomcat

        commit 1cb5fad
        Author: Dan Kortschak <dan.kortschak@elastic.co>
        Date:   Fri Apr 26 16:23:35 2024 +0930

            entityanalytics_ad: new package for Active Directory user collection (elastic#9485)

        commit 37c598f
        Author: CarsonHrusovsky <95260807+CarsonHrusovsky@users.noreply.github.com>
        Date:   Thu Apr 25 18:13:26 2024 -0500

            [BBOT] New integration for Black Lantern Security scanner (elastic#9651)

        commit d13e474
        Author: Mario Rodriguez Molins <mario.rodriguez@elastic.co>
        Date:   Thu Apr 25 11:55:39 2024 +0200

            [Buildkite] Skip install package command in serverless builds for some packages (elastic#9686)

        commit 0c2198b
        Author: Mario Rodriguez Molins <mario.rodriguez@elastic.co>
        Date:   Thu Apr 25 11:41:42 2024 +0200

            [Buildkite] Add retry suffix for logs (elastic#9703)

        commit d932e79
        Author: Simon Kötting <145989254+SimonKoetting@users.noreply.github.com>
        Date:   Thu Apr 25 07:35:45 2024 +0200

            [Exchange Server] GA of Integration, Add Dashbord Panel Titles & System Tests (elastic#9560)

            * Add Dashboard Titles

            * Add Dashboard Titles

            * Change Version to GA

            * adjust PR in Changelog

            * Add System Tests to all datstreams

            * fix imap system test config

            * remove Folder structure out of system tests sample logs

            * Fix mapping

            * Add convert for inode field

            * specify numeric_keyword_fields in system tests

        commit dba2901
        Author: Dan Kortschak <dan.kortschak@elastic.co>
        Date:   Thu Apr 25 10:21:30 2024 +0930

            rapid7_insightvm: canonicalize host.name to lower case and map subdomain to host.hostname (elastic#9665)

        commit 4284262
        Author: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
        Date:   Wed Apr 24 20:34:13 2024 +0300

            fix(fim): add auto option for backend and make it the default one (elastic#9702)

        commit c563bb3
        Author: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
        Date:   Wed Apr 24 19:40:04 2024 +0300

            [juniper_netscreen]: include log.file.device_id and log.file.inode in base-fields (elastic#9658)

            * fix(juniper_netscreen): include log.file.device_id and log.file.inode in base-fields.yml

            * fix(juniper_netscreen): update README.md

        commit f187d0d
        Author: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
        Date:   Wed Apr 24 19:11:28 2024 +0300

            [juniper_junos]: include log.file.device_id and log.file.inode in base-fields (elastic#9657)

            * fix(juniper_junos): include log.file.device_id and log.file.inode in base-fields.yml

            * fix(juniper_junos): update README.md
@pkoutsovasilis pkoutsovasilis mentioned this pull request May 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gogochan gogochan gogochan approved these changes

Assignees

@pkoutsovasilis pkoutsovasilis

Labels
bug Something isn't working integration:Juniper Netscreen Team:Security-Deployment and Devices Deployment and Devices Security team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pkoutsovasilis @elasticmachine @taylor-swanson @gogochan