Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AWS][Lambda] Fix AWS Invocations Count Issue #9669

Merged
merged 6 commits into from
Apr 24, 2024
Merged

[AWS][Lambda] Fix AWS Invocations Count Issue #9669

merged 6 commits into from
Apr 24, 2024

Conversation

agithomas
Copy link
Contributor

@agithomas agithomas commented Apr 23, 2024 •
edited
Loading

  • Bug

Proposed commit message

Update aggregation function for AWS lambda invocation metric.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Dashboard validation
  • Discover view validation
  • Field mapping validation
  • Package upgrade test

How to test this PR locally

  • elastic-package build
  • elastic-package stack up -v -d --services package-registry

Screenshots

image image

@elasticmachine
Copy link

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@agithomas agithomas marked this pull request as ready for review April 23, 2024 07:37
@agithomas agithomas requested review from a team as code owners April 23, 2024 07:37
dej611
dej611 approved these changes Apr 23, 2024
View reviewed changes
Copy link

@dej611 dej611 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review only 👍

@niraj-elastic
Copy link
Contributor

Let's update the screen shot as well.

@agithomas
Copy link
Contributor Author

Let's update the screen shot as well.

Updated the screenshot.

zmoog
zmoog approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@zmoog zmoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@agithomas agithomas merged commit 87ca061 into elastic:main Apr 24, 2024
5 checks passed
@elasticmachine
Copy link

Package aws - 2.14.2 containing this change is available at https://epr.elastic.co/search?package=aws

gizas pushed a commit that referenced this pull request Apr 26, 2024
@agithomas @gizas
[AWS][Lambda] Fix AWS Invocations Count Issue (#9669)
57bb5c6 
* Updated aggregation function for AWS lambda invocation metric.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zmoog zmoog zmoog approved these changes

@dej611 dej611 dej611 approved these changes

@muthu-mps muthu-mps muthu-mps approved these changes

@niraj-elastic niraj-elastic niraj-elastic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@agithomas @elasticmachine @niraj-elastic @zmoog @dej611 @muthu-mps